Avoid crypto random APIs where pseudo-random will do #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? These random bytes are not for an operation that requires cryptographically secure random data. We just need a strong probability of a different random number than the other party so we can establish asymetry. |
|
We talked about this over teams. We came to the conclusion that we do not need cryptographically secure random data, so the added complexity of supporting both browser and node is not worth it. This is why we decided to go with Math.random(), which is available on both platforms. |
AArnott
changed the title
AArnott
approved these changes
Oct 2, 2023
|
Do you want to rebase and retarget against v2.10 for a faster stable release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.