fix up

dotnet · Jun 28, 2023 · 1bb6e80 · 1bb6e80 · github-actions · Jun 28, 2023
1 parent 7285782
commit 1bb6e80
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml
@@ -22,7 +22,7 @@ jobs:
         run: cd test/DocumentFormat.OpenXml.Benchmarks; dotnet build -c RELEASE
         shell: pwsh
       - name: Run benchmarks
-        run: cd test/DocumentFormat.OpenXml.Benchmarks; dotnet run -c RELEASE -- results --exporters json --filter '*'
+        run: cd test/DocumentFormat.OpenXml.Benchmarks; dotnet run -c RELEASE -f net7.0 -- results --exporters json --filter '*'
         shell: pwsh
       - name: Write summary
         shell: pwsh

diff --git a/test/Directory.Build.targets b/test/Directory.Build.targets
@@ -12,7 +12,6 @@
         </Compile>
       </ItemGroup>
       <ItemGroup>
-        <!-- Need to bring this in manually as the test framework itself tries to bring in 9.0.0 -->
         <PackageReference Include="Newtonsoft.Json" />
         <PackageReference Include="System.ValueTuple" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" />

diff --git a/test/DocumentFormat.OpenXml.Benchmarks/DocumentFormat.OpenXml.Benchmarks.csproj b/test/DocumentFormat.OpenXml.Benchmarks/DocumentFormat.OpenXml.Benchmarks.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>$(LatestTargetFramework)</TargetFramework>
+    <TargetFrameworks>$(LatestTargetFramework)</TargetFrameworks>
   </PropertyGroup>
   <PropertyGroup>
     <OutputType>Exe</OutputType>
Benchmark suite	Current: `1bb6e80`	Previous: `e2b8a44`	Ratio
`DocumentFormat.OpenXml.Benchmarks.ElementMetadataTests.CreateWithInstance`	`24.28482417975153` ns (`± 0.015111741812222992`)	`26.193310494606312` ns (`± 0.8260131565293166`)	`0.93`
`DocumentFormat.OpenXml.Benchmarks.ElementMetadataTests.CreateWithGeneric`	`45.03282735745112` ns (`± 0.33548830933563406`)	`37.67914932727814` ns (`± 1.1080663276880038`)	`1.20`