Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenXmlPackage.Close and all references #1373

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Remove OpenXmlPackage.Close and all references #1373

merged 4 commits into from
Apr 3, 2023

Conversation

tomjebo
Copy link
Collaborator

@tomjebo tomjebo commented Mar 30, 2023

No description provided.

twsouthwick
twsouthwick previously approved these changes Mar 30, 2023
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a discard here.

A lot of these are for SaveAs. This seems like an awkward thing to use...

test/DocumentFormat.OpenXml.Tests/SaveAndCloneTests.cs Outdated Show resolved Hide resolved
test/DocumentFormat.OpenXml.Tests/SaveAndCloneTests.cs Outdated Show resolved Hide resolved
test/DocumentFormat.OpenXml.Tests/SaveAndCloneTests.cs Outdated Show resolved Hide resolved
test/DocumentFormat.OpenXml.Tests/SaveAndCloneTests.cs Outdated Show resolved Hide resolved
twsouthwick
twsouthwick previously approved these changes Mar 30, 2023
@tomjebo
Copy link
Collaborator Author

tomjebo commented Mar 31, 2023

/azp run

1 similar comment
@tomjebo
Copy link
Collaborator Author

tomjebo commented Apr 2, 2023

/azp run

@tomjebo
Copy link
Collaborator Author

tomjebo commented Apr 3, 2023

@twsouthwick the pipeline build ran successfully on these changes but for some reason didn't report back to this PR on github. Can you just do a quick re-review?

@tomjebo
Copy link
Collaborator Author

tomjebo commented Apr 3, 2023

/azp run

@tomjebo tomjebo merged commit e2d90ca into dotnet:main Apr 3, 2023
@tomjebo tomjebo deleted the remove_close_main branch April 6, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants