Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget.ProjectModel version used in Microsoft.DotNet.Scaffolding.Shared has a high vulnerability #2588

Closed
thompson-tomo opened this issue Nov 25, 2023 · 8 comments

Comments

@thompson-tomo
Copy link

Describe the bug

All versions of the library are using a version of Nuget.ProjectModel which has an identified vulnerability which has been fixed in newer version of the library

To reproduce

Open nuget package manager with library installed
Look at vulnerabilities of transitive packages and observe warning about vulnerability for Nuget.ProjectModel
Look at dependencies of Microsoft.DotNet.Scaffolding.Shared and observe this is the source of the vulnerable library

Expected behavior

Nuget.ProjectModel is upgraded to a version which doesn't contain vulnerability or dependency removed

Further technical details

GHSA-6qmf-mmc7-6c2p

@Regenhardt
Copy link

Regenhardt commented Dec 8, 2023

Microsoft.VisualStudio.Web.CodeGeneration.Design also references NuGet packages (.Common, .Protocol) with that vulnerability, even the recently released version 8.

@thompson-tomo
Copy link
Author

You are correct the affected package is a transitive dependency of many packages often many packages deep.

@mcurros2
Copy link

mcurros2 commented Feb 6, 2024

Any news on this? Microsoft.VisualStudio.Web.CodeGeneration.Design uses version 6.3.1, and 6.8.0 is available with no vulnerabilities. I think the references could be updated safely and repackage. A severe vulnerability will make us to uninstall this feature, and I don't know if it's possible.

Is there a workaround to update it manually?

@thompson-tomo
Copy link
Author

@mcurros2 the workaround is to add the affected package as an explicit dependency which will update the transitive package.

@thompson-tomo
Copy link
Author

6.8.0 is now being classified as impacted. Package should be updated to atleast 6.8.1

@tinohager
Copy link

Please push a new version of the package with the update of NuGet.* packages

@NotTsunami
Copy link

NotTsunami commented Mar 13, 2024

Microsoft.DotNet.Scaffolding.Shared 8.0.2 has released and this was fixed 🥳 Thanks everyone for helping get this out!

@thompson-tomo
Copy link
Author

Looks good, hence closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants