Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Identity UI accessibility fixes to scaffolding #1502

Merged
merged 1 commit into from Feb 11, 2021
Merged

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Feb 9, 2021

@HaoK HaoK requested review from deepchoudhery and a team February 9, 2021 22:55
@mkArtakMSFT
Copy link
Member

Thanks @HaoK.
I assume you just copied over the markup from the identity UI pages as is?

Copy link
Contributor

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaoK
Copy link
Member Author

HaoK commented Feb 10, 2021

@mkArtakMSFT unfortunately the files aren't identical so its a bit of a manual port of the changes

@mkArtakMSFT
Copy link
Member

Ok I think it's safe to merge given that it's a set of HTML only changes.

@deepchoudhery deepchoudhery merged commit a8e131f into main Feb 11, 2021
@deepchoudhery deepchoudhery deleted the haok/h1 branch February 11, 2021 00:42
@deepchoudhery deepchoudhery mentioned this pull request Feb 11, 2021
deepchoudhery added a commit that referenced this pull request Feb 12, 2021
* reverting to 5.0 sdk, 5.0 tfm until 6.0 stablizes (#1492)

* added lower case check for package paths (#1493)

* Port Identity UI accessibility fixes (#1502)

* added Publishing.props to update to V3 publish (#1504)

* Fixup feeds (#1498)

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: Deep Choudhery <54324771+deepchoudhery@users.noreply.github.com>

Co-authored-by: Hao Kung <HaoK@users.noreply.github.com>
Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants