Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-aspnet-codegenerator Identity scenario for minimal hosting applications. #1628

Merged
merged 7 commits into from Sep 3, 2021
Merged

dotnet-aspnet-codegenerator Identity scenario for minimal hosting applications. #1628

merged 7 commits into from Sep 3, 2021

Conversation

deepchoudhery
Copy link
Contributor

@deepchoudhery deepchoudhery commented Aug 27, 2021 •
edited

  • Moved files from

    • src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/CodeChange --->
      src/Shared/Microsofot.DotNet.Scaffolding.Shared/CodeModifier/CodeChange
    • src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectExtensions.cs -->
      src/Shared/Microsofot.DotNet.Scaffolding.Shared/CodeModifier/ProjectExtensions.cs

  • Edited DocumentBuilder.AddUsings() to return a modified SyntaxNode root instead of replacing current root using DocumentEditor.ReplaceNode

  • Added Microsoft.DotNet.Scaffolding.Shared assembly to share code between dotnet-aspnet-codegenerator and dotnet-msidentity scenarios. To do with MsBuild, CodeAnalysis editing, console logging, etc.

Identity specific:

  • Added identityMinimalHostingChanges.json for minimal hosting identity related code changes.
  • Added DocumentBuilder.AddGlobalStatements to add global statements to Program.cs
  • Edited .cshtml from interpolated strings to using string A + B. Razor templating was breaking with interpolated strings (hard to debug). Tracking issue to revert/update the templates

@deepchoudhery deepchoudhery self-assigned this Aug 27, 2021
@deepchoudhery deepchoudhery merged commit 0a40930 into main Sep 3, 2021
@deepchoudhery deepchoudhery deleted the dev/decho/identityForMinimalHosting branch September 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayrkn vijayrkn Awaiting requested review from vijayrkn

@abpiskunov abpiskunov Awaiting requested review from abpiskunov

@phil-allen-msft phil-allen-msft Awaiting requested review from phil-allen-msft

@phenning phenning Awaiting requested review from phenning

@zahalzel zahalzel Awaiting requested review from zahalzel

@BillHiebert BillHiebert Awaiting requested review from BillHiebert

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deepchoudhery