Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service principal when exposing API scopes #1931

Merged
merged 2 commits into from Jun 13, 2022

Conversation

zahalzel
Copy link
Contributor

Fixes a regression where service principals were not being created when creating app registrations, causing problems with accessing Web APIs. Also small fix to appsettings parsing, to prevent null refs.

Copy link
Contributor

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zahalzel zahalzel merged commit 5eab606 into main Jun 13, 2022
zahalzel added a commit that referenced this pull request Jun 13, 2022
* Add service principal when exposing API scopes

* Remove commented method
zahalzel added a commit that referenced this pull request Jun 13, 2022
* Add service principal when exposing API scopes

* Remove commented method
zahalzel added a commit that referenced this pull request Jun 13, 2022
* Fix config for blazor wasm (#1927)

* Add service principal when exposing API scopes (#1931)

* Add service principal when exposing API scopes

* Remove commented method

* Add service principal when exposing API scopes

* Remove commented method

* expose scopes

* Fix scopes

* Fix config for blazor wasm
zahalzel added a commit that referenced this pull request Jun 13, 2022
* Fix config for blazor wasm

* Fix config for blazor wasm (#1927)

* Add service principal when exposing API scopes (#1931)

* Add service principal when exposing API scopes

* Remove commented method

* Add service principal when exposing API scopes

* Remove commented method

* expose scopes

* Fix scopes

* Fix config for blazor wasm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants