Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking if endpoints class is static, if not, creating one. #2002

Merged
merged 1 commit into from Sep 1, 2022

Conversation

deepchoudhery
Copy link
Contributor

@deepchoudhery deepchoudhery commented Sep 1, 2022

Check if endpoints class is static,

  • if it IS, continue as usual, create endpoints method in that class.

  • if it IS NOT, create a new static class in the same file (at the end of the file) and add the scaffolded endpoints method to the newly created class.

  • additional fix where Microsoft.EntityFrameworkCore namespace is added if a DbContext is being used, not just when a DbContext namespace is present (in the endpoints class).

@deepchoudhery deepchoudhery self-assigned this Sep 1, 2022
Copy link
Contributor

@zahalzel zahalzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question on string equality, otherwise looks good

@deepchoudhery deepchoudhery merged commit 79a092d into main Sep 1, 2022
@deepchoudhery deepchoudhery deleted the dev/decho/static-class-endpoints-fix branch September 1, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants