Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MsIdentity] parse csproj file and add tfm(s). #2016

Merged
merged 2 commits into from Sep 13, 2022
Merged

[MsIdentity] parse csproj file and add tfm(s). #2016

merged 2 commits into from Sep 13, 2022

Conversation

deepchoudhery
Copy link
Contributor

added ProcessCsprojFile and ProcessTfm to get a project's target framework(s) from the .csproj file.

  • ProcessCsprojFile uses XDocument to get all children nodes in the csproj file

@deepchoudhery deepchoudhery self-assigned this Sep 13, 2022
zahalzel
zahalzel approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@zahalzel zahalzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

test/Shared/Microsoft.DotNet.Scaffolding.Shared.Tests/ProjectModifierHelperTests.cs Outdated Show resolved Hide resolved
@deepchoudhery deepchoudhery merged commit f1b0ee4 into main Sep 13, 2022
@deepchoudhery deepchoudhery deleted the dev/decho/msidentity-add-tfm branch September 13, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zahalzel zahalzel zahalzel approved these changes

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepchoudhery @zahalzel