Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output for app registrations #2144

Merged
merged 1 commit into from Dec 7, 2022
Merged

Fix output for app registrations #2144

merged 1 commit into from Dec 7, 2022

Conversation

zahalzel
Copy link
Contributor

@zahalzel zahalzel commented Dec 7, 2022

A few small fixes:

  • if GetGraphObjects method fails, puts the output in the JsonResponse Output field rather than the Content field
  • if there are no app registrations, but everything succeeded, returns a JsonResponse with empty list rather than failing

deepchoudhery
deepchoudhery approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@deepchoudhery deepchoudhery left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's add a test for the empty app registration scenario (or an issue open is good)

@zahalzel zahalzel merged commit eb326ff into main Dec 7, 2022
@zahalzel zahalzel deleted the dev/zahalzel/output_fixes branch December 7, 2022 22:48
deepchoudhery pushed a commit that referenced this pull request Jan 4, 2023
@zahalzel @deepchoudhery
Fix output for app registrations (#2144)
763ee1a 
Adding issue: #2146
@deepchoudhery deepchoudhery mentioned this pull request Jan 4, 2023
Merged
deepchoudhery added a commit that referenced this pull request Jan 6, 2023
@deepchoudhery @zahalzel
dotnet-msidentity 2.0.1 servicing update (#2197)
c2dc990 
* output error for app registrations, and formatting nit (#2129)

* Fix output for app registrations (#2144)

Adding issue: #2146

* Log token authentication failure to JsonResponse, Refactor getting app registrations (#2149)

* Refactor getting app registrations

* Fix test

* Refactor ConsoleLogger failure logging

* Fix newline (#2181)

* bumping dotnet-msidentity version

* Refactor console logger and catch app provisioning exceptions (#2189)

* Refactor console logger

* Exit environment after logging failure

* Add try/catch to app registration creation

* Refactor LogFailure to LogFailureAndExit

Co-authored-by: Zachary Halzel <zahalzel@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepchoudhery deepchoudhery deepchoudhery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zahalzel @deepchoudhery