Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change useSqlite to useSqLite for VS scenarios #2214

Merged
merged 1 commit into from Jan 10, 2023
Merged

change useSqlite to useSqLite for VS scenarios #2214

merged 1 commit into from Jan 10, 2023

Conversation

deepchoudhery
Copy link
Contributor

@deepchoudhery deepchoudhery commented Jan 10, 2023 •
edited

VS uses Sqlite scenarios by adding the option useSqLite.

  • Microsoft.Extensions.CommandLineUtils is not case-friendly. Changed this typo in add database providers for ef scenarios #2139 so reverting it back now.
  • adding useSqLite back to parameter defintion json files so its available to display in --help.

@deepchoudhery deepchoudhery self-assigned this Jan 10, 2023
zahalzel
zahalzel approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@zahalzel zahalzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@ajcvickers
Copy link
Member

Just FYI, the official casing for SQLite is "SQLite".

@deepchoudhery
Copy link
Contributor Author

Just FYI, the official casing for SQLite is "SQLite".

Good to know yeah, reflected here. Switching to using -dbProvider next update.

@deepchoudhery deepchoudhery merged commit 5435355 into main Jan 10, 2023
@deepchoudhery deepchoudhery deleted the dev/decho/fix-useSqlite branch January 10, 2023 20:47
deepchoudhery added a commit that referenced this pull request Jan 10, 2023
@deepchoudhery
change useSqlite to useSqLite for VS scenarios (#2214)
e066f61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zahalzel zahalzel zahalzel approved these changes

@vijayrkn vijayrkn Awaiting requested review from vijayrkn

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepchoudhery @ajcvickers @zahalzel