Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --useSqlite for mac scenarios #2241

Merged
merged 16 commits into from Jan 23, 2023

Conversation

deepchoudhery
Copy link
Contributor

@deepchoudhery deepchoudhery commented Jan 18, 2023

  • reverting all auto updates for upgrading aspnetcore, efcore, and runtimes changes from 7.0.3 to previous GA versions.
  • added UseSqlite2 with option name useSqlite
    • for backwards compat. for VS Mac scenarios.
  • whitespace fixes based on new .editorconfig file.
  • bumping dotnet-aspnet-codegenerator version to 7.0.3

Copy link
Contributor

@zahalzel zahalzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@vijayrkn
Copy link
Contributor

@deepchoudhery - why are the dependencies reverted to 7.0.1 instead of 7.0.2? I understand why it should not be 7.0.3

@deepchoudhery deepchoudhery merged commit 4339775 into release/7.0 Jan 23, 2023
@deepchoudhery deepchoudhery deleted the dev/decho/fix-useSqlite-mac branch January 23, 2023 01:40
deepchoudhery added a commit that referenced this pull request Jan 23, 2023
* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230113.1 (#2234)"

This reverts commit 5f9352e.

* Revert "[release/7.0] Update dependencies from dotnet/aspnetcore (#2232)"

This reverts commit fe0e787.

* Revert "Update dependencies from https://github.com/dotnet/aspnetcore build 20230112.7 (#2229)"

This reverts commit 86d5b52.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230112.8 (#2230)"

This reverts commit 9063024.

* Revert "[release/7.0] Update dependencies from dotnet/aspnetcore (#2192)"

This reverts commit 2530114.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230112.2 (#2226)"

This reverts commit cdf6b6f.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230111.6 (#2222)"

This reverts commit 5efa6d8.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230111.2 (#2218)"

This reverts commit bc7f508.

* Revert "Update dependencies from https://github.com/dotnet/arcade build 20230110.4 (#2219)"

This reverts commit a707da7.

* Revert "[release/7.0] Update dependencies from dotnet/efcore (#2191)"

This reverts commit a311109.

* adding --useSqlite back

* added comment.

* updating 7.0.1 dependencies to 7.0.2

* remove ShortName for duplicate UseSqlite CommandLineOption

* minor fix

* minor fix, cmd line validation for razor page crud
deepchoudhery added a commit that referenced this pull request Jan 24, 2023
* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230113.1 (#2234)"

This reverts commit 5f9352e.

* Revert "[release/7.0] Update dependencies from dotnet/aspnetcore (#2232)"

This reverts commit fe0e787.

* Revert "Update dependencies from https://github.com/dotnet/aspnetcore build 20230112.7 (#2229)"

This reverts commit 86d5b52.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230112.8 (#2230)"

This reverts commit 9063024.

* Revert "[release/7.0] Update dependencies from dotnet/aspnetcore (#2192)"

This reverts commit 2530114.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230112.2 (#2226)"

This reverts commit cdf6b6f.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230111.6 (#2222)"

This reverts commit 5efa6d8.

* Revert "Update dependencies from https://github.com/dotnet/efcore build 20230111.2 (#2218)"

This reverts commit bc7f508.

* Revert "Update dependencies from https://github.com/dotnet/arcade build 20230110.4 (#2219)"

This reverts commit a707da7.

* Revert "[release/7.0] Update dependencies from dotnet/efcore (#2191)"

This reverts commit a311109.

* adding --useSqlite back

* added comment.

* updating 7.0.1 dependencies to 7.0.2

* remove ShortName for duplicate UseSqlite CommandLineOption

* minor fix

* minor fix, cmd line validation for razor page crud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants