More self-review comments

dotnet · May 24, 2024 · 5eca8c3 · 5eca8c3
1 parent 37637f5
commit 5eca8c3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/sources/SilkTouch/Mods/Common/ModUtils.cs b/sources/SilkTouch/Mods/Common/ModUtils.cs
@@ -544,10 +544,10 @@ out _
         syntax.AttributeLists.GetNativeTypeName(SyntaxKind.ReturnKeyword);
 
     /// <summary>
-    ///
+    /// Determines whether this is a <see cref="PredefinedTypeSyntax"/> representing an integral type.
     /// </summary>
-    /// <param name="syn"></param>
-    /// <returns></returns>
+    /// <param name="syn">The type to check.</param>
+    /// <returns>Whether it's an integer.</returns>
     public static bool IsInteger(this TypeSyntax syn) =>
         (syn as PredefinedTypeSyntax)?.Keyword.Kind()
             is SyntaxKind.ULongKeyword

diff --git a/sources/SilkTouch/Mods/MixKhronosData.cs b/sources/SilkTouch/Mods/MixKhronosData.cs
@@ -243,7 +243,9 @@ public async Task BeforeJobAsync(string key, SilkTouchConfiguration config)
         job.TypeMap.TryAdd("GLbitfield", "uint");
         if (specPath is null)
         {
-            // There is act
+            // No metadata, can't continue. It'd be odd if the Khronos mod is being used in this case. There was once
+            // actually a use case for it, but the ArrayParameterTransformer (once Khronos-specific) is no longer
+            // Khronos-specific.
             return;
         }