Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Visual Studio Code support #273

Closed
ZacharyPatten opened this issue Aug 17, 2020 · 8 comments · Fixed by #322
Closed

Feature Request: Visual Studio Code support #273

ZacharyPatten opened this issue Aug 17, 2020 · 8 comments · Fixed by #322
Labels
area-Meta enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ZacharyPatten
Copy link

Feature Request

Add .vscode folder with extensions, tasks, launches, and (optionally) settings .json files so people can run the examples from Visual Studio Code rather than Visual Studio without additional setup.
@ZacharyPatten ZacharyPatten added the enhancement New feature or request label Aug 17, 2020
@ZacharyPatten
Copy link
Author

I volunteer to add these files if desired.

@Perksey Perksey added area-Meta good first issue Good for newcomers help wanted Extra attention is needed labels Aug 17, 2020
@Perksey
Copy link
Member

Perksey commented Aug 17, 2020

I don't see why not :D My only concern is with these files becoming out of date as neither myself nor Kai use VSCode.

@HurricanKai
Copy link
Member

I personally would prefer using launchSettings.json, I believe this is supported by all IDEs.

@ZacharyPatten
Copy link
Author

ZacharyPatten commented Aug 17, 2020 •
edited
Loading

Yeah. They can become out of date, but they are really helpful for new devs who don't want/have VS or are on Linux. I have example files here:
https://github.com/ZacharyPatten/Towel/tree/master/.vscode

However there are a few things that you may not want to add to your files. Mainly, I apply custom syntax highlighting in my settings folder that you guys may not want.

The main things that will become out are file paths. If you move file paths or change the build target (.NET Core 2.0 -> 3.1 for example) the file path in the launch/task will need to be updated.

@HurricanKai
Copy link
Member

We don't check in Rider or VS files, why VSC? I'd be on board with launchSettings as they, like .editorconfig are shared across IDEs.

@Perksey
Copy link
Member

Perksey commented Aug 17, 2020

I'd be on board with launchSettings as they, like .editorconfig are shared across IDEs.

Did not know this. launchSettings.json sounds like the way to go then.

@HurricanKai
Copy link
Member

In regards to Hacktoberfest, to clarify, we would appreciate contribution of launchSettings.json file(s) for now.

@moozzyk moozzyk mentioned this issue Oct 5, 2020
Merged
@Perksey Perksey mentioned this issue Oct 10, 2020
Closed
5 tasks
Perksey pushed a commit that referenced this issue Nov 5, 2020
@moozzyk
Add VS Code support for tutorials (#322)
38cb04c 
Fixes: #273

Adding tasks and launch configurations to allow running and debugging
tutorial projects directly from Visual Studio Code.
Newly added tasks also allow publishing tutorial projects and running
them under under the wather.

Verification:
- Ran each added launch configuration from VS Code
- Published a couple projects and made sure artificats were written to
  the expected location
- Ran a couple projects under the watcher
@ZacharyPatten
Copy link
Author

Nice :) Sorry I didn't have time to add these when I opened the issue. Glad someone else did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Meta enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add VS Code support for tutorials
3 participants
@ZacharyPatten @Perksey @HurricanKai