Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to SDL 2.0.14 #443

Merged
merged 11 commits into from
Apr 2, 2021
Merged

Update to SDL 2.0.14 #443

merged 11 commits into from
Apr 2, 2021

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Mar 30, 2021 •
edited
Loading

  • Updated submodule
  • Updated bindings
  • Updated native packages

HurricanKai
HurricanKai reviewed Apr 2, 2021
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good - I think this also includes the SDL nint change & m64?

src/Windowing/Silk.NET.SDL/SDL.cs Show resolved Hide resolved
@Perksey
Copy link
Member Author

Perksey commented Apr 2, 2021

Yeah. D3D9 and SDL are now 64-bit only due to ABI deviations we can't efficiently account for. In addition, SDL hasn't been updated to fix the massively breaking nint bug fix we had in rtm (or 2.1 i forget)

@HurricanKai
Copy link
Member

Awesome - don't forget about the GetWindowWMInfo thing, and then mark as ready for review, looks good to me then.

@Perksey Perksey marked this pull request as ready for review April 2, 2021 23:18
@Perksey
Copy link
Member Author

Perksey commented Apr 2, 2021

Ready to go.

@Perksey Perksey enabled auto-merge (squash) April 2, 2021 23:25
@Perksey Perksey merged commit 23f9bd4 into main Apr 2, 2021
@Perksey Perksey deleted the feature/sdl-2.0.14 branch April 2, 2021 23:41
Perksey added a commit that referenced this pull request Mar 25, 2022
@Perksey
This is the April 2021 Update (v2.3.0) & #443
ce9730d 
* Remove SDL mirror

* Add the real SDL, fix generator paths

* Regenerate D3D9 and SDL for 64-bit (build will probably fail)

* Fix build errors

* Fix fusion reactor not respecting desired names

* Update Windows and Linux binary

* Update libsilkdroid

* Update macOS binary

* Update iOS binary

* This is the April 2021 Update (v2.3.0)
@HurricanKai HurricanKai mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HurricanKai HurricanKai HurricanKai approved these changes

Assignees
No one assigned
Labels
area-Windowing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Perksey @HurricanKai