Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Signing #553

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Code Signing #553

merged 2 commits into from
Aug 4, 2021

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Jul 25, 2021

This enables code signing for all DLLs, EXEs, and more whose filenames start with Silk.NET

NuGet requires the code signing certificate to be registered with them. By default, all code signing certificates are registered under the dotnetfoundation organisation. However, we'd have to add that organisation as an owner of every single one of our packages to do that, current and future, which is not a process that can be automated today.

I've asked for help in dotnet-foundation/projects#147

@HurricanKai
Copy link
Member

Consider raising this with NuGet support.

@Perksey
Copy link
Member Author

Perksey commented Jul 25, 2021

This isn't a NuGet issue. The only thing NuGet could do to improve the situation is allow automation of ownership modification, which will require API additions and will take months to get triaged, and then presumably more months to get implemented.

The issue is that we can't reasonably add dotnetfoundation as an owner of our packages because of how many there are and how great the odds are that a new one will occasionally pop up when we generate our bindings.

I presented possible workarounds in the issue linked.

@Perksey
Copy link
Member Author

Perksey commented Aug 3, 2021

Update (for the record): some emails have been flung about within Microsoft to try and move these packages over to dotnetfoundation from the backend. No updates as of yet.

@Perksey
Copy link
Member Author

Perksey commented Aug 4, 2021

Some updates:

  • The NuGet team have said that, if we really needed, they could do some database-side changes but would prefer to make a more elegant tool in their next sprint or two so that they can better facilitate transfers like these.
  • As such, as a workaround we've just added code-signing certificate to the Silk.NET organisation until such a time comes that we can get all the packages co-ownered to dotnetfoundation.
  • This can now be merged.

@Perksey Perksey marked this pull request as ready for review August 4, 2021 18:35
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the description is ment to be just the name.

@Perksey
Copy link
Member Author

Perksey commented Aug 4, 2021

Assuming the description is ment to be just the name.

So says the example pipelines :)

@Perksey Perksey merged commit cdd5a91 into main Aug 4, 2021
@Perksey Perksey deleted the infra/code-signing branch August 4, 2021 18:43
Perksey added a commit that referenced this pull request Mar 25, 2022
* Start of Code Signing

* Remove Ultz.Native from the filelist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants