Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is the November 2021 Update (v2.10.0) #671

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Nov 5, 2021

  • Patch notes
  • Rich NuGet readmes
  • Rebranding
  • Logo-in-package
  • Configurable descriptions (paving the way for more and more specific package metadata)

@Perksey
Copy link
Member Author

Perksey commented Nov 5, 2021

Ready for review, but leaving as draft for now because

  • still have one more BuildTools change (removal of bad implicit ins) to do.

Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. can you also give me a link to this new extended NuGet functionality?

README.md Show resolved Hide resolved
- Fix native libraries not being found in some cases for self-contained executables
Silk.NET November 2021 Update

- Added support for BigInteger and Complex in the Silk.NET.Maths.Scalar APIs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a thanks to @WhiteBlackGoose here? Feel like that'd be deserved, we've not done so in the past, but it'd be a nice gesture for the future if we start putting (#PR thank you @) from now on?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<Project>
<PropertyGroup>
<SilkDescription>A small and portable mathematics and linear algebra library, useful in graphics and compute workloads.</SilkDescription>
<SilkExtendedDescription>This package has no other Silk.NET dependencies, so feel free to use it any project in any workload regardless of whether it uses other Silk.NET libraries or not. This is akin to System.Numerics.Vectors, only with extra types and generics (so any numerical type can be used rather than just float).</SilkExtendedDescription>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add something like "Supports Half, float, double, decimal, byte, sbyte, ushort, short, uint, int, ulong, long, Complex and BitInteger" just for posterity

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Perksey
Copy link
Member Author

Perksey commented Nov 5, 2021

@Perksey
Copy link
Member Author

Perksey commented Nov 5, 2021

can you also give me a link to this new extended NuGet functionality?

Logo-in-package

https://docs.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5048

Readme functionality

https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/

@Perksey Perksey marked this pull request as ready for review November 5, 2021 22:53
@Perksey
Copy link
Member Author

Perksey commented Nov 5, 2021

This has now been undrafted.

@Perksey Perksey enabled auto-merge (squash) November 5, 2021 22:54
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would never review draft PRs

@Perksey Perksey merged commit 1dde1e3 into main Nov 5, 2021
@Perksey Perksey deleted the patch/notes-2.10 branch November 5, 2021 23:24
Perksey added a commit that referenced this pull request Nov 6, 2021
* Packaging improvements, NuGet readmes, and 2.10 release notes

* Fix GitHub README rendering issues

* Attempt to fix whitespace

* push push push push push push push

* Actually fix whitespace

* Update common.props

* Update Directory.Build.props
Perksey added a commit that referenced this pull request Mar 25, 2022
* Packaging improvements, NuGet readmes, and 2.10 release notes

* Fix GitHub README rendering issues

* Attempt to fix whitespace

* push push push push push push push

* Actually fix whitespace

* Update common.props

* Update Directory.Build.props
Perksey added a commit that referenced this pull request Nov 20, 2023
* Packaging improvements, NuGet readmes, and 2.10 release notes

* Fix GitHub README rendering issues

* Attempt to fix whitespace

* push push push push push push push

* Actually fix whitespace

* Update common.props

* Update Directory.Build.props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants