Optimize Scalar.As #988
Merged
Optimize Scalar.As #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beyley
approved these changes
Aug 4, 2022
HurricanKai
requested changes
Aug 4, 2022
HurricanKai
approved these changes
Aug 4, 2022
Beyley
force-pushed
the
hotfix/scalar_as_optimization
branch
from
b191fcc
to
86b816e
Compare
Beyley
force-pushed
the
hotfix/scalar_as_optimization
branch
from
86b816e
to
ca43f14
Compare
|
I'm hoping one day this will light up, but failing that I need to add a "mono path" that stops mono from producing invalid assembly (basically just having a file with the old, unoptimized code in it. I think our blazor activity gives us reasonable evidence that it does try to specialize these generics even with the code unoptimized for CoreCLR so we may be good to do so anyway. sucks, but that's mono for you) |
Perksey
added a commit
that referenced
this pull request
Nov 20, 2023
* Optimize Scalar.As * Optimize Scalar.As * Fix mono assembler errors * Fix me spending too much time around C++ * Fix public API * Fix public API (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.