Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include 42108 and 42109 to retriable transient errors list #1215

Merged
merged 3 commits into from Aug 23, 2021
Merged

Include 42108 and 42109 to retriable transient errors list #1215

merged 3 commits into from Aug 23, 2021

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Aug 17, 2021 •
edited

Addresses #1205

Reference docs:

@cheenamalhotra cheenamalhotra linked an issue Aug 18, 2021 that may be closed by this pull request
[Synapse SQL Pools] Make SQL Errors 42108 and 42109 retriable for logins #1205
Closed
@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v4.0 via automation Aug 19, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview1 milestone Aug 19, 2021
DavoudEshtehari
DavoudEshtehari reviewed Aug 19, 2021
View reviewed changes
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these two error numbers in RetryLogicTestHelper and TransientFaultTDSServer.GetErrorMessage(), please?

@cheenamalhotra cheenamalhotra added the 🆕 Public API Use this label for new API additions to the driver. label Aug 20, 2021
@cheenamalhotra cheenamalhotra merged commit 896c4fc into dotnet:main Aug 23, 2021
SqlClient v4.0 automation moved this from In progress to Done Aug 23, 2021
@David-Engel David-Engel mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees
No one assigned
Labels
🆕 Public API Use this label for new API additions to the driver.
Projects
No open projects
SqlClient v4.0
Done
Milestone
4.0.0-preview1
Development

Successfully merging this pull request may close these issues.

[Synapse SQL Pools] Make SQL Errors 42108 and 42109 retriable for logins
2 participants
@cheenamalhotra @DavoudEshtehari