Move unused files causing heavier "AnyOS" binaries #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The "AnyOS" binaries we build for lib\netcore and lib\netstandard don't contain any source code, they just throw "Not Supported Exception". That's why anything added to those binaries (via default itemgroup without conditions) is going to only add up to size and has no use. Any new file (containing source-code) should be always added to an ItemGroup with a "non-AnyOS" condition in this case. |
DavoudEshtehari
approved these changes
Aug 24, 2021
JRahnama
approved these changes
Aug 24, 2021
|
Good to know. I'll try to be more careful in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.