Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some unit tests for SqlParameter (more to come) #191

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Add some unit tests for SqlParameter (more to come) #191

merged 1 commit into from
Sep 12, 2019

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Sep 12, 2019

relates to #56

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 12, 2019

Based on tests from https://github.com/mono/mono/blob/master/mcs/class/System.Data/Test/System.Data.SqlClient/SqlParameterTest.cs

cheenamalhotra
cheenamalhotra approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nit: Plz add a new line at the end of file in next PR, can be avoided for now.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 12, 2019

I will, unsure about your style...

@cheenamalhotra cheenamalhotra merged commit a1575fb into dotnet:master Sep 12, 2019
@cheenamalhotra cheenamalhotra added the ✔️ Tests Identifier for test related changes label Sep 12, 2019
@cheenamalhotra cheenamalhotra added this to the 1.1.0-preview1 milestone Sep 12, 2019
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@ErikEJ @cheenamalhotra
Tests | Add some unit tests for SqlParameter (more to come) (dotnet#191)
2d0690b 
Relates to dotnet#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees
No one assigned
Labels
✔️ Tests Identifier for test related changes
Projects
None yet
Milestone
1.1.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ErikEJ @cheenamalhotra