Support SuperSocketNetLib registry option for Encrypt on NetCore Windows #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 70.97% 70.67% -0.31%
==========================================
Files 305 305
Lines 61807 61807
==========================================
- Hits 43870 43681 -189
- Misses 17937 18126 +189
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| @@ -454,6 +442,18 @@ internal SqlConnectionString(string connectionString) : base(connectionString, G | |||
| } | |||
| #endif // NETFRAMEWORK | |||
|
|
|||
| if (_encrypt == SqlConnectionEncryptOption.Optional) | |||
| { // Support legacy registry encryption settings | |||
| const string folder = "Software\\Microsoft\\MSSQLServer\\Client\\SuperSocketNetLib"; | |||
There was a problem hiding this comment.
I'm wondering if this is still a valid path or not!
There was a problem hiding this comment.
It's a less-known, legacy registry path. I don't even see it in current MS docs, but it was in the netfx code (and works in netfx SDS) and support has mentioned it from some customers.
DavoudEshtehari
approved these changes
Jun 14, 2023
Kaur-Parminder
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.