Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry with SqlDataAdapter.Fill(SqlDataTable) on .NET Framework #2084

Conversation

DavoudEshtehari
Copy link
Member

fixes #1591

add unit tests
@DavoudEshtehari DavoudEshtehari added 🐛 Bug! Something isn't right ! netfx labels Jul 6, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview3 milestone Jul 6, 2023
@DavoudEshtehari DavoudEshtehari added this to In progress in SqlClient v5.2 via automation Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.61 🎉

Comparison is base (aa2d36a) 70.05% compared to head (c1f662f) 70.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2084      +/-   ##
==========================================
+ Coverage   70.05%   70.66%   +0.61%     
==========================================
  Files         305      305              
  Lines       61943    61943              
==========================================
+ Hits        43393    43771     +378     
+ Misses      18550    18172     -378     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.40% <ø> (-0.11%) ⬇️
netfx 69.29% <100.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 74.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

SqlClient v5.2 automation moved this from In progress to Reviewer approved Jul 12, 2023
@DavoudEshtehari DavoudEshtehari merged commit 554fd2e into dotnet:main Jul 12, 2023
132 checks passed
SqlClient v5.2 automation moved this from Reviewer approved to Done Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right ! netfx
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Retry not working with SqlDataAdapter.Fill(table) (.net framework)
3 participants