Consolidation of localization #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t string Encrypt option into SqlConnectionEncryptionOption type.
… than not work?
…o convert string Encrypt option into SqlConnectionEncryptionOption type." This reverts commit 5c505a1.
…o convert string Encrypt option into SqlConnectionEncryptionOption type." This reverts commit 5c505a1.
… 15 less than not work?" This reverts commit cde0430.
Changed csproj to make Strings.resx shows up under netcore/src/Resources and netfx/src/Resources still. Change netfx csproj RootNamespace to Microsoft.Data.SqlClient.
…esults are still identical.
arellegue
requested review from
David-Engel,
JRahnama,
DavoudEshtehari and
Kaur-Parminder
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
=======================================
Coverage 70.01% 70.02%
=======================================
Files 306 305 -1
Lines 61962 62050 +88
=======================================
+ Hits 43383 43450 +67
- Misses 18579 18600 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
David-Engel
approved these changes
Aug 1, 2023
DavoudEshtehari
requested changes
Aug 3, 2023
There was a problem hiding this comment.
It seems that time for following the same dynamic generation pattern on .netcore for ResourceNames type as well.
Also, I'd rather mix the .netcore-specific "StringsHelper.NetCore.cs" with the new common cs file.
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
Made netcore Strings.ResourceNames.cs dynamically created. Udated MDS nuspec. Added localization unit tests.
|
.NetCore ResourceNames auto generation pattern has been added. Also, StringsHelper.NetCore.cs has been merged to StringsHelper.cs. |
…gsSource.targets.
src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalizationTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/tools/scripts/GenerateResourceStringsSource.ps1
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalizationTest.cs
Outdated
Show resolved
Hide resolved
Added License info to GenerateResourceStringsSource.ps1.
src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalizationTest.cs
Outdated
Show resolved
Hide resolved
Removed a blank line in LocalizationTest.cs.
DavoudEshtehari
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.