Fix | Fix issue with SqlCommand OnStatementCompleted event not being triggered #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! Do you have a build I can use? Otherwise I'll grab one from these validation builds when they complete and let you know if it solves our issue. |
|
Microsoft.Data.SqlClient.PR216.zip |
David-Engel
reviewed
Sep 25, 2019
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandCompletedTest.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Sep 25, 2019
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
David-Engel
approved these changes
Sep 26, 2019
cheenamalhotra
force-pushed
the
fix212
branch
from
504f14e
to
c970861
Compare
David-Engel
reviewed
Sep 26, 2019
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandCompletedTest.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
📍 Push to Commit Feed
|
NuGet Package for validation: |
yukiwongky
pushed a commit
to yukiwongky/SqlClient
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #212
@Charles-Gagnon
Please verify the fix and let us know.