Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TDSParserStateObject.StateSnapshot packet list mangement and reimplment #2164

Merged
merged 1 commit into from
Oct 25, 2023

move PacketData and list management to shared and reimplement as doub…

c033395
Select commit
Failed to load commit list.
Merged

Merge TDSParserStateObject.StateSnapshot packet list mangement and reimplment #2164

move PacketData and list management to shared and reimplement as doub…
c033395
Select commit
Failed to load commit list.
Azure Pipelines / CI-SqlClient succeeded Sep 20, 2023 in 3h 30m 46s

Build #26312 had test failures

Details

Tests

  • Failed: 10 (0.00%)
  • Passed: 318,878 (98.52%)
  • Other: 4,788 (1.48%)
  • Total: 323,676
Code coverage

  • 79390 of 111830 lines covered (70.99%)

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

EXEC#L0

EXEC(0,0): Error Message: 

Check failure on line 187 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

build.proj#L187

build.proj(187,5): Error MSB3073: The command "dotnet test "src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj" -p:Configuration=Release -p:TargetnetcoreVersion=net7.0 --no-build -l "console;verbosity=normal" --collect "Code coverage" -p:TestSet=2 --results-directory TestResults -p:TestTargetOS=Windowsnetcoreapp --filter "category!=nonnetcoreapptests&category!=failing&category!=nonwindowstests" "--logger:trx;LogFilePrefix=Manual-Windowsnetcoreapp-2"" exited with code 1.

Check failure on line 3876 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Build log #L3876

Process 'msbuild.exe' exited with code '1'.

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

EXEC#L0

EXEC(0,0): Error Message: 

Check failure on line 1 in Microsoft.Data.SqlClient.Tests.SqlConnectionBasicTests.TransientFaultDisabledTest(errorCode: 40613)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.Tests.SqlConnectionBasicTests.TransientFaultDisabledTest(errorCode: 40613)

Assert.Throws() Failure
Expected: typeof(Microsoft.Data.SqlClient.SqlException)
Actual:   (No exception was thrown)
Raw output
   at Microsoft.Data.SqlClient.Tests.SqlConnectionBasicTests.TransientFaultDisabledTest(UInt32 errorCode) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\FunctionalTests\SqlConnectionBasicTests.cs:line 127

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.TestDelayedAsyncTimeout(api: ExecuteReaderAsync, commonObj: "Command", delayPeriod: 5000, marsEnabled: False)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.TestDelayedAsyncTimeout(api: ExecuteReaderAsync, commonObj: "Command", delayPeriod: 5000, marsEnabled: False)

System.AggregateException : One or more errors occurred. (Invalid operation. The connection is closed.)
---- System.InvalidOperationException : Invalid operation. The connection is closed.
Raw output
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.RunTest(AsyncAPI api, String commonObj, Int32 timeoutDelay, Boolean marsEnabled) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\AsyncTest\AsyncTimeoutTest.cs:line 109
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.TestDelayedAsyncTimeout(AsyncAPI api, String commonObj, Int32 delayPeriod, Boolean marsEnabled) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\AsyncTest\AsyncTimeoutTest.cs:line 32
   at InvokeStub_AsyncTimeoutTest.TestDelayedAsyncTimeout(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
----- Inner Stack Trace -----
   at Microsoft.Data.SqlClient.TdsParserStateObject.ReadSniSyncOverAsync() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 1200
   at Microsoft.Data.SqlClient.TdsParserStateObject.TryReadNetworkPacket() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 1126
   at Microsoft.Data.SqlClient.TdsParserStateObject.TryPrepareBuffer() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParserStateObject.cs:line 1027
   at Microsoft.Data.SqlClient.TdsParserStateObject.TryReadByte(Byte& value) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 372
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 2621
   at Microsoft.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 1924
   at Microsoft.Data.SqlClient.TdsParser.ProcessAttention(TdsParserStateObject stateObj) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 7741
   at Microsoft.Data.SqlClient.TdsParser.ProcessPendingAck(TdsParserStateObject stateObj) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 360
   at Microsoft.Data.SqlClient.TdsParserStateObject.ResetCancelAndProcessAttention() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 196
   at Microsoft.Data.SqlClient.TdsParserStateObject.CloseSession() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParserStateObject.cs:line 697
   at Microsoft.Data.SqlClient.SqlCommand.PutStateObject() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5465
   at Microsoft.Data.SqlClient.SqlCommand.ReliablePutStateObject() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5454
   at Microsoft.Data.SqlClient.SqlCommand.EndExecuteReaderInternal(IAsyncResult asyncResult) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2207
   at Microsoft.Data.SqlClient.SqlCommand.EndExecuteReaderAsync(IAsyncResult asyncResult) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2168
   at Microsoft.Data.SqlClient.SqlCommand.<>c.<InternalExecuteReaderAsync>b__203_1

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlConfigurationManagerReliabilityTest.InvalidRetryMethodName(methodName: "CREATEINCREMENTALRETRYPROVIDER")

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlConfigurationManagerReliabilityTest.InvalidRetryMethodName(methodName: "CREATEINCREMENTALRETRYPROVIDER")

Assert.Throws() Failure
Expected: typeof(Microsoft.Data.SqlClient.SqlException)
Actual:   typeof(System.InvalidOperationException): ExecuteReader requires an open and available Connection. The connection's current state is closed.
---- System.InvalidOperationException : ExecuteReader requires an open and available Connection. The connection's current state is closed.
Raw output
   at Microsoft.Data.SqlClient.SqlCommand.ValidateCommand(Boolean isAsync, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5359
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4671
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4647
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2125
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2076
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.<>c__DisplayClass9_0.<NoneRetriableExecuteFail>b__1() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 371
----- Inner Stack Trace -----
   at Microsoft.Data.SqlClient.SqlCommand.ValidateCommand(Boolean isAsync, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5359
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4671
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 4647
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2125
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2076
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlCommandReliabilityTest.<>c__DisplayClass9_0.<NoneRetriableExecuteFail>b__1() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\RetryLogic\SqlCommandReliabilityTest.cs:line 371

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.TestDelayedAsyncTimeout(api: ExecuteScalarAsync, commonObj: "Command", delayPeriod: 8000, marsEnabled: True)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-SqlClient

Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.TestDelayedAsyncTimeout(api: ExecuteScalarAsync, commonObj: "Command", delayPeriod: 8000, marsEnabled: True)

System.AggregateException : One or more errors occurred. (Object reference not set to an instance of an object.)
---- System.NullReferenceException : Object reference not set to an instance of an object.
Raw output
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.Wait()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.RunTest(AsyncAPI api, String commonObj, Int32 timeoutDelay, Boolean marsEnabled) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\AsyncTest\AsyncTimeoutTest.cs:line 111
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AsyncTimeoutTest.TestDelayedAsyncTimeout(AsyncAPI api, String commonObj, Int32 delayPeriod, Boolean marsEnabled) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\AsyncTest\AsyncTimeoutTest.cs:line 32
   at InvokeStub_AsyncTimeoutTest.TestDelayedAsyncTimeout(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
----- Inner Stack Trace -----
   at Microsoft.Data.SqlClient.TdsParserStateObject.CheckSetResetConnectionState(UInt32 error, CallbackType callbackType) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParserStateObject.cs:line 688
   at Microsoft.Data.SqlClient.TdsParserStateObject.ReadSniSyncOverAsync() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 1200
   at Microsoft.Data.SqlClient.TdsParserStateObject.TryReadNetworkPacket() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 1126
   at Microsoft.Data.SqlClient.TdsParserStateObject.TryPrepareBuffer() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParserStateObject.cs:line 1027
   at Microsoft.Data.SqlClient.TdsParserStateObject.TryReadByte(Byte& value) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 372
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 2621
   at Microsoft.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 1924
   at Microsoft.Data.SqlClient.TdsParser.ProcessAttention(TdsParserStateObject stateObj) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 7741
   at Microsoft.Data.SqlClient.TdsParser.ProcessPendingAck(TdsParserStateObject stateObj) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParser.cs:line 360
   at Microsoft.Data.SqlClient.TdsParserStateObject.ResetCancelAndProcessAttention() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\TdsParserStateObject.netcore.cs:line 196
   at Microsoft.Data.SqlClient.TdsParserStateObject.CloseSession() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\TdsParserStateObject.cs:line 697
   at Microsoft.Data.SqlClient.SqlCommand.PutStateObject() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5465
   at Microsoft.Data.SqlClient.SqlCommand.ReliablePutStateObject() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 5454
   at Microsoft.Data.SqlClient.SqlCommand.EndExecuteReaderAsync(IAsyncResult asyncResult) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\netcore\src\Microsoft\Data\SqlClient\SqlCommand.cs:line 2168
   at Microsoft.Data.SqlClient.SqlCommand.<>c.<Inter