Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Support Georgian collation #2194

Merged
merged 3 commits into from Oct 25, 2023

Conversation

DavoudEshtehari
Copy link
Member

@DavoudEshtehari DavoudEshtehari commented Oct 24, 2023

fixes #2182
Adds support Georgian collation with code page 1252.

…Georgian

# Conflicts:
#	src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderTest.cs
@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label Oct 24, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview4 milestone Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 68.70% <100.00%> (+0.05%) ⬆️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 71.38% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@JRahnama JRahnama merged commit 6beab6a into dotnet:main Oct 25, 2023
134 checks passed
@Giorgi
Copy link

Giorgi commented Feb 29, 2024

@DavoudEshtehari Thanks from Georgia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The Collation specified by SQL Server is not supported." for Georgian_Modern_Sort_CI_AS collation
5 participants