Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get last error when LoadLibrary fails #225

Merged
merged 1 commit into from Sep 27, 2019

Conversation

David-Engel
Copy link
Contributor

@David-Engel David-Engel commented Sep 26, 2019

Provide the underlying error in the inner exception when we fail to load SNI.dll.

@David-Engel David-Engel added this to the 1.1.0 milestone Sep 26, 2019
@David-Engel David-Engel added this to In progress in SqlClient v1.1.0 via automation Sep 26, 2019
@Wraith2
Copy link
Contributor

Wraith2 commented Sep 27, 2019

Assuming you want the inner exception so you can get the error message not just the error code, LGTM.

SqlClient v1.1.0 automation moved this from In progress to Reviewer approved Sep 27, 2019
@cheenamalhotra cheenamalhotra merged commit 33bad3a into dotnet:master Sep 27, 2019
SqlClient v1.1.0 automation moved this from Reviewer approved to Done Sep 27, 2019
@cheenamalhotra cheenamalhotra modified the milestones: 1.1.0, 1.1.0-preview1 Oct 2, 2019
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@David-Engel David-Engel deleted the SNILoadError branch March 4, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants