Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Fix unit test for SPN to include port number with Managed SNI #2281

Merged
merged 21 commits into from
Feb 26, 2024
Merged

Fix | Fix unit test for SPN to include port number with Managed SNI #2281

merged 21 commits into from
Feb 26, 2024

Commits on Dec 18, 2023

  1. Remove ActiveIssue to test pipeline.

    @arellegue
    arellegue committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    9c776f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Fix SPN port number Unit Test to use TCP and NP connection strings an… 

    …d Named Instance with or without port number.
    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f84884c View commit details
    Browse the repository at this point in the history

  2. Try adding retry and delay in creating and using the connection objec… 

    …t to fix intermittent issue in the pipeline.
    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    36c235f View commit details
    Browse the repository at this point in the history

  3. Added IsUsingManagedSNI annotation since reflection is using ManagedS… 

    …NI dll.
    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0caa4ce View commit details
    Browse the repository at this point in the history

  4. Add wrapper for all required annotations for the unit test as it is t… 

    …oo long.
    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c47a16e View commit details
    Browse the repository at this point in the history

  5. Removed all Sleeps as they are not needed.

    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    64c0103 View commit details
    Browse the repository at this point in the history

  6. Add annotation to skip .net framework for SPN port unit test.

    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    af685d3 View commit details
    Browse the repository at this point in the history

  7. Put [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] so … 

    …its the first annotation as the unit test did not skip.
    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6076e8e View commit details
    Browse the repository at this point in the history

  8. Removed SkipOnTargetFramework as it did not stop the unit test from r… 

    …unning in pipeline. Added conditional compilation instead.
    @arellegue
    arellegue committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    bea5513 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Add validation of InstanceName within the ConditionalThreory annotation.

    @arellegue
    arellegue committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    fa556f5 View commit details
    Browse the repository at this point in the history

  2. Removed and sorted using references.

    @arellegue
    arellegue committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6ace809 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Fix ParseDataSource named pipe data source detection to be case insen… 

    …sitive.
    @arellegue
    arellegue committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    660d992 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Applied PR review suggesstions.

    @arellegue
    arellegue committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    192a1e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Moved named pipe protocol port usage assert message to line 138 and u… 

    …sed Assert.Fail.
    @arellegue
    arellegue committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8a93097 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Removed all source codes that handle named pipe protocol.

    @arellegue
    arellegue committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    00d9a3c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Removed unwanted comments as they cause code bloat. 

    Rename variables to what they are.
Changed ConditionalTheory to ConditionalFact and get the port number of named instance from Sql Browser.
    @arellegue
    arellegue committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    41366f6 View commit details
    Browse the repository at this point in the history

  2. Add SPN pattern validation and use Assert.Equal to compare expected p… 

    …ort number agains port number returned in SPN.
    @arellegue
    arellegue committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    baa3ab9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'main' into FixUnitTestForSPNPortNumber

    @arellegue
    arellegue committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    53a13e6 View commit details
    Browse the repository at this point in the history

  2. Added validation for DataSource.

    @arellegue
    arellegue committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    2bc3f7c View commit details
    Browse the repository at this point in the history

  3. Added assertion if DataSource is valid.

    @arellegue
    arellegue committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c131562 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Replace If (port > 0) with Assert( port > 0, ...)

    @arellegue
    arellegue committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0c5ed6f View commit details
    Browse the repository at this point in the history