Remove support for .NET Standard 2.0 and 2.1 #2386
Conversation
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNICommon.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
- Coverage 72.69% 71.05% -1.64%
==========================================
Files 313 296 -17
Lines 61737 60725 -1012
==========================================
- Hits 44878 43150 -1728
- Misses 16859 17575 +716
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@JRahnama All net462 builds pass, despite being labelled with netstandard2.1 - but maybe the label is misleading? |
labels are misleading, I will try to make a test pipeline for this PR today. Update: failures are all due to building netstandard tests which are expected. |
|
@JRahnama any progress on the pipeline Update? |
|
@David-Engel @JRahnama Is this still on the radar? |
DavoudEshtehari
added
the
🔨 Breaking Change
|
A new file with .NET Standard support has been added in pull request #2310. |
|
I will merge with latest main and remove it. |
|
How is it going with the pipeline update?? |
|
We're going to set up a test pipeline to verify the outcome of this change. Once it's merged, we'll replace it with the current CI. |
|
@DavoudEshtehari sounds great. I will Update tomorrow |
|
You should be able to see this pipeline, which has been setup for your branch. |
There was a problem hiding this comment.
LGTM! In addition to the CI pipeline, we recently pushed a few YAML files for production pipeline into the GitHub repo, and they should be updated and verified internally. We'll prepare the necessary internal changes to ensure that these PRs are merged with the least time gap.
|
@DavoudEshtehari Thanks, let me know if there is anything else I need to do |
fix bad merge
|
@DavoudEshtehari I have updated to latest main, hope you can help get this in soon 😄 |
|
Pipeline without net standard to verify the result. |
|
@JRahnama @David-Engel Are you able to have a look now? |
src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
Outdated
Show resolved
Hide resolved
|
@DavoudEshtehari Ready for another attempt with the new pipeline 😄 |
|
@ErikEJ Thank you for doing this. Your support is greatly appreciated. This PR is ready to merge when the conflict is addressed. 🥳 🎉 |
|
@JRahnama Conflicts resolved - and thanks for the kind words |
- Complementary code change of PR [#2386](#2386). - This should be merged after merging the related PR to remove support of .NET Standard in the production pipeline. - The first commit has the related PR's changes(review them on GH). - After having merged the related GH PR and updating the CI pipeline, I'll sync with this PR to unify the changes and get passed the pipeline. - Only the YAML changes under the `eng` folder should be reviewed (ignore the other changes as they are identical to the GH). - Introduced `oneBranchType` parameter to switch between **Official** and **NonOfficial** templates - [new sample run](https://dev.azure.com/SqlClientDrivers/ADO.Net/_build/results?buildId=86908&view=results) Related work items: #30122
fixes #2340