-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SqlConnectionOverrides for OpenAsync() API #2433
base: main
Are you sure you want to change the base?
Add support for SqlConnectionOverrides for OpenAsync() API #2433
Conversation
..\doc\snippets\Microsoft.Data.Sql\SqlDataSourceEnumerator.xml = ..\doc\snippets\Microsoft.Data.Sql\SqlDataSourceEnumerator.xml | ||
..\doc\snippets\Microsoft.Data.Sql\SqlNotificationRequest.xml = ..\doc\snippets\Microsoft.Data.Sql\SqlNotificationRequest.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert the irrelevant changes in the solution file, please?
{ | ||
SqlConnectionStringBuilder connectionStringBuilder = new(DataTestUtility.TCPConnectionString) | ||
{ | ||
InitialCatalog = "DoesNotExist0982532435423", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's less likely to exist.
InitialCatalog = "DoesNotExist0982532435423", | |
InitialCatalog = DataTestUtility.GetUniqueNameForSqlServer("DoesNotExist", false), |
await Assert.ThrowsAsync<SqlException>(async () => await sqlConnection.OpenAsync(CancellationToken.None)); | ||
timer.Stop(); | ||
duration = timer.Elapsed; | ||
Assert.True(duration.Seconds > 5, $"Connection OpenAsync() with retries took less time than expected. Expect > 5 sec with transient fault handling. Took {duration.Seconds} sec."); // sqlConnection.OpenAsync(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assert.True(duration.Seconds > 5, $"Connection OpenAsync() with retries took less time than expected. Expect > 5 sec with transient fault handling. Took {duration.Seconds} sec."); // sqlConnection.OpenAsync(); | |
Assert.True(duration.Seconds > 5, $"Connection OpenAsync() with retries took less time than expected. Expect > 5 sec with transient fault handling. Took {duration.Seconds} sec."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my current understanding, the existing default is to not apply transient fault handling for OpenAsync. This changes the default to applying transient fault handling.
It seems like there are two options if we want to make a change now:
- modify this change to retain the current default behavior
- do this change, but only apply it on a new (major?) version
However, given what we've learned about the slow, serial nature of OpenAsync, part of me feels like we should wait to do this change until general async performance is improved.
I would advocate for waiting.
As the name suggests, introduces new API:
Previously, we skipped addiing overrides to OpenAsync in PR #463 due to no transient fault handling, but with recent PR #1983 we now enable transient fault handling by default for
OpenAsync()
too.To support fail fast behavior in OpenAsync(), we need to allow passing
SqlConnectionOverrides
inOpenAsync()
too.Additional context:
dotnet/efcore#33399
#29