Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Fixes driver behavior of sending Attention signal for successful Bulk Copy operation #308

Merged
merged 4 commits into from Nov 15, 2019
Merged

Fix | Fixes driver behavior of sending Attention signal for successful Bulk Copy operation #308

merged 4 commits into from Nov 15, 2019

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v1.1.0 via automation Nov 14, 2019
@cheenamalhotra cheenamalhotra added this to the 1.1.0 milestone Nov 14, 2019
@cheenamalhotra cheenamalhotra added the Backport to CoreFx Fixes which need to be ported back to System.Data.SqlClient label Nov 14, 2019
saurabh500
saurabh500 reviewed Nov 14, 2019
View reviewed changes
Copy link

@saurabh500 saurabh500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

cheenamalhotra and others added 2 commits November 14, 2019 13:47
@cheenamalhotra @saurabh500
Apply suggestions from code review
7802f2e 
Co-Authored-By: Saurabh Singh <saurabh.singh@microsoft.com>
@cheenamalhotra
Address review comments
1932a30
SqlClient v1.1.0 automation moved this from In progress to Reviewer approved Nov 15, 2019
This was referenced Nov 15, 2019
Closed
Merged
@cheenamalhotra cheenamalhotra merged commit c402a17 into dotnet:master Nov 15, 2019
SqlClient v1.1.0 automation moved this from Reviewer approved to Done Nov 15, 2019
This was referenced Nov 15, 2019
Merged
Closed
Closed
@cheenamalhotra cheenamalhotra deleted the fixAttention branch June 30, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh500 saurabh500 saurabh500 left review comments

@David-Engel David-Engel David-Engel approved these changes

Assignees
No one assigned
Labels
Backport to CoreFx Fixes which need to be ported back to System.Data.SqlClient
Projects
No open projects
SqlClient v1.1.0
  
Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheenamalhotra @saurabh500 @David-Engel