Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow large UDT buffers for netfx #456

Merged
merged 2 commits into from Apr 8, 2020
Merged

Conversation

alsicbv
Copy link
Contributor

@alsicbv alsicbv commented Mar 5, 2020

fixes #329 for netfx

The fix in #340 was only for netcore. Issue #329 still exists when using EF core on Net Framework.

/cc @ajcvickers @aprognimak @Wraith2

@Wraith2
Copy link
Contributor

Wraith2 commented Mar 5, 2020

It'll do the job. I'd prefer the new exception type and message from the other PR to come over as well but it should almost never be thrown so it isn't a huge probem.

@alsicbv
Copy link
Contributor Author

alsicbv commented Mar 25, 2020

It'll do the job. I'd prefer the new exception type and message from the other PR to come over as well but it should almost never be thrown so it isn't a huge probem.

@Wraith2 What should be done to have this reviewed and merged? It seems I don't have rights to request a review.

@Wraith2
Copy link
Contributor

Wraith2 commented Mar 25, 2020

You just wait i'm afraid.

@cheenamalhotra
Copy link
Member

Hi @alsicbv

As @Wraith2 mentioned before, please include all necessary changes from NetCore PR here. We are only waiting for that in order to get this merged.

@Wraith2
Copy link
Contributor

Wraith2 commented Mar 25, 2020

In all fairness to @alsicbv as a contributor I can only make suggestions and it wasn't clear that it was my suggestion that was being waited for. I think both he and I assumed that the PR was waiting for review from the owner side.

@cheenamalhotra
Copy link
Member

Oops!
You do bring valuable suggestions @Wraith2 , I'll make a note to highlight the same next time!

@alsicbv
Copy link
Contributor Author

alsicbv commented Mar 25, 2020

Oops!
You do bring valuable suggestions @Wraith2 , I'll make a note to highlight the same next time!

Ok, it wasn't clear to me... Thanks for clarifying, I'm not working tomorrow so I'll do it on Friday!

@dnfclas
Copy link

dnfclas commented Mar 27, 2020

CLA assistant check
All CLA requirements met.

@alsicbv
Copy link
Contributor Author

alsicbv commented Mar 27, 2020

Hi @cheenamalhotra

As @Wraith2 mentioned before, please include all necessary changes from NetCore PR here. We are only waiting for that in order to get this merged.

I've made all changes from the original PR

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion

@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v2.0.0 via automation Apr 7, 2020
@cheenamalhotra cheenamalhotra added this to the 2.0.0-preview3 milestone Apr 7, 2020
@cheenamalhotra cheenamalhotra moved this from In progress to Review in progress in SqlClient v2.0.0 Apr 7, 2020
@cheenamalhotra cheenamalhotra merged commit 7ec2095 into dotnet:master Apr 8, 2020
SqlClient v2.0.0 automation moved this from Review in progress to Done Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

UDT parameters are limited to 64K
4 participants