Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Fix | Prohibit DtdProcessing on XmlTextReader instance in .NET Core #884

Merged
merged 1 commit into from Jan 18, 2021
Merged

Security Fix | Prohibit DtdProcessing on XmlTextReader instance in .NET Core #884

merged 1 commit into from Jan 18, 2021

Conversation

cheenamalhotra
Copy link
Member

The setting is already set in NetFx.
Fixes vulnerability.

@cheenamalhotra cheenamalhotra mentioned this pull request Jan 15, 2021
Merged
@cheenamalhotra cheenamalhotra added this to In Progress in SqlClient v3.0 via automation Jan 15, 2021
@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview1 milestone Jan 15, 2021
SqlClient v3.0 automation moved this from In Progress to Reviewer Approved Jan 16, 2021
DavoudEshtehari
DavoudEshtehari approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good practice to set the critical parameters even they're default behaviours.

@cheenamalhotra cheenamalhotra merged commit f23e0d6 into dotnet:master Jan 18, 2021
SqlClient v3.0 automation moved this from Reviewer Approved to Done Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinazhou karinazhou karinazhou approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SqlClient v3.0
Done
Milestone
3.0.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheenamalhotra @karinazhou @DavoudEshtehari