tiny perf change #900
Merged
tiny perf change #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
reviewed
Feb 3, 2021
| @@ -82,7 +82,7 @@ public void Reset() | |||
| _language = null; | |||
| if (_deltaDirty) | |||
| { | |||
| _delta = new SessionStateRecord[_maxNumberOfSessionStates]; | |||
There was a problem hiding this comment.
Nice catch on call to GC and allocations.
JRahnama
approved these changes
Feb 3, 2021
cheenamalhotra
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #889 there was one item which generated a huge number of arrays and discarded them causing GC pressure. I tracked and identified all uses of the code that generates it. There is only one
SessionStateRecordused and no other location keeps a reference to it so it is safe to clear the array for re-use instead of creating and entirely new one each time.