Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocast #1235

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Autocast #1235

wants to merge 7 commits into from

Conversation

haytham2597
Copy link

@haytham2597 haytham2597 commented Feb 11, 2024

Soon i will try make AMP (Automatic Mixed Precision) with GradScaler.

@haytham2597
Copy link
Author

@dotnet-policy-service agree

int8_t THSTorch_get_autocast_gpu_dtype()
{
//TODO: Implement AUTOCAST AMP AND GRADSCALER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a work-in-progress PR, or something you're submitting for approval and merging? If the latter, then please create an issue to track "to do" items and add some unit tests.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U can merging this if you want, this dont break anything (far as I know). But may useful for someone who want use that autocast function manually. My idea and plan is to make AMP, GradScaler, these modules use the functions I added.
Thank, I will try take into account about issue "to do" and unit tests. Sorry.

@NiklasGustafsson
Copy link
Contributor

@haytham2597 -- thank you for your first PR! Much appreciated. Please see the comment I made in the review.

@haytham2597
Copy link
Author

Do not merge, i keep have some issue.

@haytham2597 haytham2597 marked this pull request as draft February 18, 2024 18:47
@NiklasGustafsson
Copy link
Contributor

Lots of errors in the build on everything except the .NET FX builds (which don't have System.Range):

https://dev.azure.com/dotnet/TorchSharp/_build/results?buildId=103093&view=logs&j=80b813b5-9a08-5859-11a8-dc0e5b556e52&t=d3977768-5d05-5555-eccf-169680cb7093

@lintao185
Copy link

I am very happy to see this proposal.

@NiklasGustafsson
Copy link
Contributor

@haytham2597 -- just a gentle ping! I think this PR would be very valuable, but it's still a draft, and thus I will not merge it. I also had some comments in my review.

@haytham2597
Copy link
Author

@haytham2597 -- just a gentle ping! I think this PR would be very valuable, but it's still a draft, and thus I will not merge it. I also had some comments in my review.

Yeah, but sorry i am very busy with studied and work. I need managed very well about my time for making some progress on this pull requests, i mean this is very useful for me too.
But i can provide some idea about this if you want continue.

  • While the autocast is inside on scope automatically convert the tensor to dtype of autocast.
    For example
torch.Tensor a;
using(var ac = torch.NewAutocast()){
      torch.Tensor b = a;
      torch.Tensor c = torch.arange(...)
}

The b and c should automatically converted to float16 (if that is dtype of mixed precision from f32) including all weight/bias of modules that found inside i mean the module, example: ResNet should passed to mixed precision.

The idea Is very similar that you do with

using (var d = torch.NewDisposeScope())

And in outer scope need back to original dtype. Because the neural should backward with original dtype (on my understood)
With my external THS_Autocast u can determine the dtype that should passed/work and if is enabled/disabled too
I don't know if I explained myself correctly, but feel free to ask.

@NiklasGustafsson
Copy link
Contributor

Yeah, no pressure!

We all have other things to do, so I understand completely. Just wanted to let you know we haven't forgotten about your work, and that it will be appreciated, if and when you find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants