Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch.histogram #960

Merged
merged 2 commits into from Mar 17, 2023
Merged

Add torch.histogram #960

merged 2 commits into from Mar 17, 2023

Conversation

ChengYen-Tang
Copy link
Contributor

@ChengYen-Tang ChengYen-Tang commented Mar 16, 2023

@ChengYen-Tang
Copy link
Contributor Author

ChengYen-Tang commented Mar 16, 2023

@NiklasGustafsson ,
The bins of numpy.histogram can use some preset formulas. I think it is also supported in TorchSharp, because tensorboard #936 will need it. What do you think?

I will use enum.
https://numpy.org/doc/stable/reference/generated/numpy.histogram.html
https://numpy.org/doc/stable/reference/generated/numpy.histogram_bin_edges.html#numpy.histogram_bin_edges
image

@NiklasGustafsson
Copy link
Contributor

I like it a lot. Definitely use enums, we try to do that across the board. It's cleaner, statically typed, and sets up for Intellisense goodness in VS.

@GeorgeS2019
Copy link

@ChengYen-Tang

Do you have plan to check if it is possible to display what you have contributed e.g. Add torch. Histogram to polyglot notebook?

@NiklasGustafsson NiklasGustafsson merged commit 9df0990 into dotnet:main Mar 17, 2023
1 check passed
@ChengYen-Tang
Copy link
Contributor Author

@ChengYen-Tang

Do you have plan to check if it is possible to display what you have contributed e.g. Add torch. Histogram to polyglot notebook?

It will be tested with the tensorboard feature at that time

This was referenced Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants