[BaseTasks] fix \-delimited paths on macOS
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests in xamarin-android have started failing with:
libfoo.so : error XA4301: Cannot determine ABI of native library 'libfoo.so'.
Move this file to a directory with a valid Android ABI name such as 'libs/armeabi-v7a/'.
Where the test in question sets `Link=x86\libfoo.so`:
https://github.com/xamarin/xamarin-android/blob/bf63c3d116b38459678cb3aefd2f5826e78c385e/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/XASdkTests.cs#L115
This only fails on macOS and works fine on Windows. I didn't consider
this case in 90d7621.
I've added test cases for `\`, and added a `string.Replace()` that
should solve the problem on macOS.
I added test cases for `null` input as well.
dellis1972
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in xamarin-android have started failing with:
Where the test in question sets
Link=x86\libfoo.so:https://github.com/xamarin/xamarin-android/blob/bf63c3d116b38459678cb3aefd2f5826e78c385e/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/XASdkTests.cs#L115
This only fails on macOS and works fine on Windows. I didn't consider
this case in 90d7621.
I've added test cases for
\, and added astring.Replace()thatshould solve the problem on macOS.
I added test cases for
nullinput as well.