Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed of ResolveSdks task #2374

Closed
radekdoulik opened this issue Nov 2, 2018 · 0 comments
Closed

Improve speed of ResolveSdks task #2374

radekdoulik opened this issue Nov 2, 2018 · 0 comments
Assignees
@radekdoulik

Comments

@radekdoulik
Copy link
Member

Use cached value for JdkJvmPath to keep ResolveSdks task fast as it is used on every build.

Context: #2153 (review)
@radekdoulik radekdoulik self-assigned this Nov 2, 2018
radekdoulik added a commit to radekdoulik/xamarin-android that referenced this issue Nov 5, 2018
@radekdoulik
[ResolveSdksTask] cache JdkJvmPath value
1a6b388 
Implements dotnet#2374

As the ResolveSdks task is used in every build, try to make it faster.

I tried to measure few builds and the time went from ~540ms to ~240ms
per 3 calls. (there were also some longer builds with cached value as
well. I think it is just a fluctuation I see on my old notebook)
radekdoulik added a commit to radekdoulik/xamarin-android that referenced this issue Nov 5, 2018
@radekdoulik
[ResolveSdksTask] cache JdkJvmPath value
b49a1a8 
Implements dotnet#2374

As the `ResolveSdks` task is used in every build, try to make it
faster.

I tried to measure few builds and the time went from ~540ms to ~240ms
per 3 calls. (there were also some longer builds with cached value as
well. I think it is just a fluctuation I see on my old notebook)
radekdoulik added a commit to radekdoulik/xamarin-android that referenced this issue Nov 5, 2018
@radekdoulik
[ResolveSdksTask] cache JdkJvmPath value
1568e64 
Implements dotnet#2374

As the `ResolveSdks` task is used in every build, try to make it
faster.

I tried to measure few builds and the time went from ~540ms to ~240ms
per 3 calls. (there were also some longer builds with cached value as
well. I think it is just a fluctuation I see on my old notebook)
@radekdoulik radekdoulik mentioned this issue Nov 5, 2018
Merged
radekdoulik added a commit that referenced this issue Nov 5, 2018
@radekdoulik
[ResolveSdksTask] cache JdkJvmPath value
1dc4b9c 
Implements #2374

As the `ResolveSdks` task is used in every build, try to make it
faster.

I tried to measure few builds and the time went from ~540ms to ~240ms
per 3 calls. (there were also some longer builds with cached value as
well. I think it is just a fluctuation I see on my old notebook)
@jonathanpeppers jonathanpeppers mentioned this issue Nov 8, 2018
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@radekdoulik