Add a bunch of Make targets to help rebuilding Mono runtime and BCL #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
reviewed
Nov 15, 2017
| rebuild-help: | ||
| @echo Helper targets to rebuild the Mono runtime and BCL assemblies | ||
| @echo | ||
| @echo " rebuild-mono" |
There was a problem hiding this comment.
I'd call this rebuild-mono-runtime to make it clear that it only builds the runtime.
| @echo " of whether a cached copy was used." | ||
| @echo | ||
| $(foreach arch,$(ALL_JIT_ABIS),$(call MonoArchRebuildHelp,$(arch))) | ||
| @echo " rebuild-bcl-assembly ASSEMBLY=bcl_assembly_name" |
There was a problem hiding this comment.
and this one maybe rebuild-mono-bcl-assembly?
the ASSEMBLY=bcl_assembly_name doesn't tell me whether I need to use System.Core or System.Core.dll, probably better to use a concrete example.
grendello
force-pushed
the
build-helpers
branch
4 times, most recently
from
5e96e76
to
eae97b2
Compare
akoeplinger
reviewed
Nov 15, 2017
Documentation/DevelopmentTips.md
Outdated
| # of whether a cached copy was used. | ||
| rebuild-mono | ||
|
|
||
| # Rebuild and install Mono runtime for the armeabi architecture only regardless |
There was a problem hiding this comment.
nit: indentation.
This says Rebuild **and install** Mono while the above only says Rebuild, is that intentional i.e. does it just build and not install? Same in the rebuild-help target.
akoeplinger
reviewed
Nov 15, 2017
| echo In order to build host Mono for $(OS) please enable it in Configuration.Override.props file and ; \ | ||
| echo Run the following command: make rebuild-mono ; \ | ||
| echo Unable to rebuild all BCL assemblies ; \ | ||
| fi |
This basically implements the steps described in Documentation/DevelopmentTips.md for the runtime and BCL assembles. Short help is available by running make rebuild-help
grendello
force-pushed
the
build-helpers
branch
from
eae97b2
to
c17178a
Compare
jonpryor
pushed a commit
that referenced
this pull request
Aug 24, 2022
Fixes: #7234 Changes: dotnet/java-interop@a5756ca...e31d9c6 * dotnet/java-interop@e31d9c62: Context: #7285 (comment) (#1029) * dotnet/java-interop@d3ea180c: [generator] Add support for `[ObsoletedOSPlatform]` (#1026) * dotnet/java-interop@6d1ae4ee: [generator] Remove [Obsolete] style compatibility hacks. (#1025) * dotnet/java-interop@440c05ee: [generator] Refactor logic for applying [Obsolete] attributes (#1024) * dotnet/java-interop@9b1d3ab7: [Localization] Import translated resx files (#1018) `generator` can now emit `[ObsoletedOSPlatformAttribute]`. Requires: - Update `Mono.Android.targets` to pass `lang-feature=obsoleted-platform-attributes` to `generator` when building for .NET 7+ - Update `acceptable-breakages-vReference-net7.0.txt` to account for removing existing `[Obsolete]` attributes in favor of the new ones, for .NET 7+ only
jonathanpeppers
pushed a commit
that referenced
this pull request
Aug 24, 2022
Fixes: #7234 Changes: dotnet/java-interop@a5756ca...e31d9c6 * dotnet/java-interop@e31d9c62: Context: #7285 (comment) (#1029) * dotnet/java-interop@d3ea180c: [generator] Add support for `[ObsoletedOSPlatform]` (#1026) * dotnet/java-interop@6d1ae4ee: [generator] Remove [Obsolete] style compatibility hacks. (#1025) * dotnet/java-interop@440c05ee: [generator] Refactor logic for applying [Obsolete] attributes (#1024) * dotnet/java-interop@9b1d3ab7: [Localization] Import translated resx files (#1018) `generator` can now emit `[ObsoletedOSPlatformAttribute]`. Requires: - Update `Mono.Android.targets` to pass `lang-feature=obsoleted-platform-attributes` to `generator` when building for .NET 7+ - Update `acceptable-breakages-vReference-net7.0.txt` to account for removing existing `[Obsolete]` attributes in favor of the new ones, for .NET 7+ only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically implements the steps described in
Documentation/DevelopmentTips.md for the runtime and BCL assembles. Short help
is available by running
make rebuild-help