Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xamarin.Android.Build.Tasks] _CreateAapt2VersionCache slow due to wildcard usage #2124

Merged
merged 4 commits into from
Sep 5, 2018
Merged

[Xamarin.Android.Build.Tasks] _CreateAapt2VersionCache slow due to wildcard usage #2124

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04be9da
[Xamarin.Android.Build.Tasks] `_CreateAapt2VersionCache` slow due to …
dellis1972 Aug 31, 2018
8a23194
Formatting fixes
dellis1972 Aug 31, 2018
e66c879
Fixed up Paths
dellis1972 Aug 31, 2018
6a0aa32
Rework to put Condition on ItemGroup
dellis1972 Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
<Target Name="_CreateAapt2VersionCache"
DependsOnTargets="_ReadAapt2VersionCache"
AfterTargets="_SetLatestTargetFrameworkVersion"
Condition="'$(_AndroidUseAapt2)' == 'True'"
Condition="'$(_AndroidUseAapt2)' == 'True' And '$(_Aapt2Version)' != '@(_Aapt2VersionCache)'"
>
<MakeDir Directories="$(IntermediateOutputPath)" Condition="!Exists('$(IntermediateOutputPath)')" />
<WriteLinesToFile
Expand All @@ -793,9 +793,10 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
Lines="$(_Aapt2Version)"
Overwrite="true"
/>
<ItemGroup>
<_CompiledFlataArchive Include="$(IntermediateOutputPath)\**\*.flata"/>
<_CompiledFlataStamp Include="$(IntermediateOutputPath)\**\compiled.stamp"/>
<ItemGroup Condition="'$(_Aapt2Version)' != '@(_Aapt2VersionCache)'">
<_CompiledFlataArchive Include="$(_AndroidLibrayProjectIntermediatePath)**\*.flata" />
<_CompiledFlataArchive Include="$(IntermediateOutputPath)\*.flata" />
<_CompiledFlataStamp Include="$(_AndroidLibrayProjectIntermediatePath)**\compiled.stamp" />
</ItemGroup>
<Delete Files="@(_CompiledFlataArchive);@(_CompiledFlataStamp)" Condition="'$(_Aapt2Version)' != '@(_Aapt2VersionCache)'" />
</Target>
Expand Down