Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to xamarin/Java.Interop/master@c19794e6 #4569

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

jonpryor
Copy link
Member

Changes: dotnet/java-interop@80b4667...c19794e

Various .csproj files updated to deal with changes from
dotnet/java-interop@9b88ce79, which added a new Crc64.Table.cs file
and requires use of C# unsafe code.

@jonpryor jonpryor mentioned this pull request Apr 16, 2020
@jonpryor
Copy link
Member Author

Duplicate of PR #4555.

@grendello
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Changes: dotnet/java-interop@80b4667...c19794e

  * dotnet/java-interop@c19794e: [build] Support building with JetBrains OpenJDK 11 (dotnet#629)
  * dotnet/java-interop@6d7266d: [crc64] Change the hash prefix back to `crc64` (dotnet#628)
  * dotnet/java-interop@7fe3a11: [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (dotnet#627)
  * dotnet/java-interop@9b88ce7: [performance] Improve speed of our CRC-64 hasher (dotnet#624)
  * dotnet/java-interop@1032c0e: [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (dotnet#622)
  * dotnet/java-interop@93df5a2: [generator] simplify life with 'var' in generated code  (dotnet#621)

Various `.csproj` files updated to deal with changes from
dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file
and requires use of C# unsafe code.

Bump the expected sizes of `.apk` files, as dotnet/java-interop@9b88ce7
increased the size of `Mono.Android.dll`.
@jonpryor jonpryor merged commit 64e99c3 into dotnet:master Apr 18, 2020
@jonpryor jonpryor mentioned this pull request Apr 18, 2020
@brendanzagaeski
Copy link
Contributor

Draft release notes

Here are the notes I plan to include for this pull request:

### Build and deployment performance

  * [Java.Interop GitHub PR 624](https://github.com/xamarin/java.interop/pull/624),
    [Java.Interop GitHub PR 627](https://github.com/xamarin/java.interop/pull/627),
    [Java.Interop GitHub PR 628](https://github.com/xamarin/java.interop/pull/628):
    Update the CRC-64 algorithm used during builds to take advantage of a more
    efficient calculation technique.  This reduced the total incremental build
    time from about 8.7 second to about 8.5 seconds for a small Xamarin.Forms app
    when one line of a C# file was changed between builds.

### Issues fixed

#### Application and library build and deployment

  * [Java.Interop GitHub PR 622](https://github.com/xamarin/java.interop/pull/622):
    *warning : Failed to read ... with debugging symbols. Retrying to load it
    without it.* and *Mono.Cecil.Cil.SymbolsNotMatchingException: Symbols were
    found but are not matching the assembly* could appear during builds, for
    example for projects using obfuscation tools.  To align more closely with
    the behavior of other common .NET project types that do not warn about
    mismatched debugger symbols, Xamarin.Android projects now log these as
    informational messages instead of warnings.

To suggest any edits to this, feel free to reply in this PR, in the corresponding Java.Interop PRs, or add a Documentation/release-notes/4569.md file with the new suggestion. Thanks in advance!

I believe the last sentence of the Java.Interop GitHub PR 622 note about "other common .NET project types" is accurate and worth mentioning, but any comments or corrections are welcome. (See dotnet/java-interop#622 (comment) for additional context.)

jonpryor added a commit that referenced this pull request Apr 23, 2020
Changes: dotnet/java-interop@ec4f819...6608c59

  * dotnet/java-interop@6608c59 [generator] Fix generated code that caused CS0169 warnings. (#625)
  * dotnet/java-interop@0537eb1 Bump to xamarin/xamarin-android-tools/d16-7@310c5cf0
  * dotnet/java-interop@59d86de [generator] Add nullable reference types (NRT) support. (#563)
  * dotnet/java-interop@64c2719 [build] Support building with JetBrains OpenJDK 11 (#629)
  * dotnet/java-interop@5a21381 [crc64] Change the hash prefix back to `crc64` (#628)
  * dotnet/java-interop@933876c [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (#627)
  * dotnet/java-interop@05c0d7d [performance] Improve speed of our CRC-64 hasher (#624)
  * dotnet/java-interop@6100554 [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (#622)
  * dotnet/java-interop@d736086 [generator] simplify life with 'var' in generated code  (#621)

Various `.csproj` files updated to deal with changes from
dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file
and requires use of C# unsafe code.

Bump the expected sizes of `.apk` files, as dotnet/java-interop@9b88ce7
increased the size of `Mono.Android.dll`.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants