[AOT] Pass the hybrid option to AOT compiler, if enabled
#7263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Aug 16, 2022
lambdageek
approved these changes
Aug 16, 2022
grendello
force-pushed
the
aot-hybrid-option
branch
from
d07e5e0
to
36ac3d2
Compare
Fixes: dotnet#7088 When the AOT hybrid mode is enabled via the `<AndroidAotMode>Hybrid</AndroidAotMode>` MSBuild property, we failed to inform the AOT compiler about its desired mode by omitting the `hybrid` argument from the list of options passed to the compiler via `--aot` The same would apply to the full AOT mode. Add `hybrid` and `full` options to the AOT compiler command line, if enabled via the `AndroidAotMode` MSBuild property. Mode is set after processing the `AotAdditionalArguments` MSBuild property. The `AndroidAotMode` property should always be the definitive source of AOT compiler mode, as it specifies the options directly supported by us. Note that the AOT compiler doesn't appear to validate options passed to it too rigorously, so setting multiple modes in some way, may have weird/invalid effects. I don't think it's our place to verify the modes, thus I'm not adding any code to that effect.
grendello
force-pushed
the
aot-hybrid-option
branch
from
36ac3d2
to
9936862
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
pushed a commit
that referenced
this pull request
Aug 22, 2022
Fixes: #7088 When the AOT hybrid mode is enabled when the `$(AndroidAotMode)` MSBuild property is set to `Hybrid`, we failed to inform the AOT compiler about its desired mode by omitting the `hybrid` argument from the list of options passed to the compiler via `--aot`. The same would apply to the full AOT mode. Add `hybrid` and `full` options to the AOT compiler command line, if enabled via the `$(AndroidAotMode)` MSBuild property. The mode is set after processing the `$(AndroidAotAdditionalArguments)` MSBuild property. The `$(AndroidAotMode)` property should always be the definitive source of AOT compiler mode, as it specifies the options directly supported by us. Note that the AOT compiler doesn't appear to validate options passed to it too rigorously, so setting multiple modes in some way, may have weird/invalid effects. I don't think it's our place to verify the modes, thus I'm not adding any code to that effect.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 23, 2022
* main: Bump r8 from 3.3.28 to 3.3.75 (dotnet#7292) [Xamarin.Android.Build.Tasks] Pass `hybrid` to AOT, if enabled (dotnet#7263) Bump to lz4/lz4@5ff83968 [v1.9.4] (dotnet#7262) [Mono.Android] add "built-in" delegate for MAUI+non-Shell (dotnet#7267)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 23, 2022
* mm-runtime: Implement some requested changes Bump r8 from 3.3.28 to 3.3.75 (dotnet#7292) [Xamarin.Android.Build.Tasks] Pass `hybrid` to AOT, if enabled (dotnet#7263) Bump to lz4/lz4@5ff83968 [v1.9.4] (dotnet#7262) [Mono.Android] add "built-in" delegate for MAUI+non-Shell (dotnet#7267)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7088
When the AOT hybrid mode is enabled via the
<AndroidAotMode>Hybrid</AndroidAotMode>MSBuild property, we failed toinform the AOT compiler about its desired mode by omitting the
hybridargument from the list of options passed to the compiler via
--aotThe same would apply to the full AOT mode.
Add
hybridandfulloptions to the AOT compiler command line, ifenabled via the
AndroidAotModeMSBuild property.Mode is set after processing the
AotAdditionalArgumentsMSBuildproperty. The
AndroidAotModeproperty should always be the definitivesource of AOT compiler mode, as it specifies the options directly
supported by us.
Note that the AOT compiler doesn't appear to validate options passed to
it too rigorously, so setting multiple modes in some way, may have
weird/invalid effects. I don't think it's our place to verify the
modes, thus I'm not adding any code to that effect.