Update MSBuild locator to not resolve SDKs newer than the runtime #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericstj mentioned in #36 (comment) that a workaround is to target net6.0 in the tool. @safern Should we also add Eric's suggested change? I can address that separately. I'll merge this. |
carlossanlop
approved these changes
Mar 4, 2021
|
Are you sure it'll be safe to analyze projects which require a newer SDK / MSBuild using an older one? What if those projects use features only available in the newer MSBuild/SDK? |
Yeah that is a good point. I think we should update the Roslyn we are using and target the tool to 6.0. |
This was referenced Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why this was failing is because the old MSBuild locator was resolving the newest SDK regardless of the runtime that the tool was running on. This: microsoft/MSBuildLocator#92 fixed that issue and only returns SDKs that are same or earlier than the runtime the tool is running on.
cc: @carlossanlop