Haiku: Update arcade support #13755
Merged
Haiku: Update arcade support #13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
from
10106c9
to
af775fd
Compare
1 task
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
4 times, most recently
from
7e4ec38
to
7b784d7
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
2 times, most recently
from
0b315b6
to
1d0176a
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
2 times, most recently
from
62a9525
to
d752f5e
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
from
d752f5e
to
b0a6ea7
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
from
b0a6ea7
to
480f2d9
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
from
480f2d9
to
1d6ce99
Compare
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
from
1d6ce99
to
4df669b
Compare
- Fix Haiku toolchain detection code. - Register Haiku to XUnit test platforms.
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-toolchain
branch
from
4df669b
to
6d1d15d
Compare
am11
approved these changes
Aug 30, 2023
am11
reviewed
Aug 30, 2023
| @@ -207,6 +207,7 @@ elseif(ILLUMOS) | |||
| set(CMAKE_CXX_STANDARD_LIBRARIES "${CMAKE_CXX_STANDARD_LIBRARIES} -lssp") | |||
| elseif(HAIKU) | |||
| set(CMAKE_SYSROOT "${CROSS_ROOTFS}") | |||
| set(CMAKE_PROGRAM_PATH "${CMAKE_PROGRAM_PATH};${CROSS_ROOTFS}/cross-tools-x86_64/bin") | |||
|
|
|||
| set(TOOLSET_PREFIX ${TOOLCHAIN}-) | |||
| function(locate_toolchain_exec exec var) | |||
There was a problem hiding this comment.
We could hoist this function out of this if-else block and reuse it for both Haiku and illumos. (perhaps as a separate PR)
ViktorHofer
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check: