Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tizen riscv64 rootfs and cross build support #14035

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

gbalykov
Copy link
Member

@gbalykov
Copy link
Member Author

cc @am11

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
cc @janvorli, @akoeplinger

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@HJLeee HJLeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

Copy link
Member

@clamp03 clamp03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@gbalykov
Copy link
Member Author

@am11 @janvorli can this be merged?

@janvorli
Copy link
Member

@gbalykov can you please rebase the change on the latest main?

@gbalykov
Copy link
Member Author

@janvorli done

@am11
Copy link
Member

am11 commented Sep 20, 2023

@ViktorHofer, can we lift the "must rebase" restriction from shell scripts which are not used in this repo at all? (which begs the old question; do these scripts really belong here? 😅)

@ViktorHofer
Copy link
Member

@ViktorHofer, can we lift the "must rebase" restriction from shell scripts which are not used in this repo at all? (which begs the old question; do these scripts really belong here? 😅)

Unsure what you mean by that. @janvorli would you be able to provide an answer to am11's question?

@am11
Copy link
Member

am11 commented Sep 26, 2023

@ViktorHofer, I was referring to these merging policies:
image

Files under eng/common/cross are not used by the CI in this repository. Can we exclude this path from CI trigger?

@ViktorHofer
Copy link
Member

Files under eng/common/cross are not used by the CI in this repository. Can we exclude this path from CI trigger?

Good question for @dotnet/arcade-contrib folks

@akoeplinger akoeplinger merged commit 3661d72 into dotnet:main Oct 11, 2023
11 checks passed
@gbalykov
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants