Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official copy of the Arcade templates that is compatible with 1ES… #14525

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

riarenas
Copy link
Member

@riarenas riarenas commented Feb 28, 2024

… pipeline templates schema

#14524

Adds a new set of templates that are compatible with the 1ES PT schema.

For now, these are mostly just a carbon copy of the public templates, some notable changes to show the kinds of improvements / cleanup we can make afterwards:

  • The post-build.yml stage does not run SDL anymore as that's supposed to be taken care of by the official pipeline templates.
  • The pool-providers template only gets you a variable for an internal pool, this will error out if trying to run in the open with the $(dncengpublicbuildpool) variable.

I used these templates to build Symreader here: https://dnceng.visualstudio.com/internal/_build/results?buildId=2390282&view=results

To double check:

@riarenas
Copy link
Member Author

I'll try to come up with something to get us a decent diff between this and the unofficial templates to see what the actual changes were

dougbu
dougbu previously approved these changes Feb 29, 2024
eng/common/templates-official/job/job.yml Show resolved Hide resolved
@riarenas
Copy link
Member Author

I'll try to come up with something to get us a decent diff between this and the unofficial templates to see what the actual changes were

I've been failing at this so far, still trying to get something easier to look at but I wouldn't wait on that.

AlitzelMendez
AlitzelMendez previously approved these changes Feb 29, 2024
mmitche
mmitche previously approved these changes Feb 29, 2024
@riarenas riarenas dismissed stale reviews from mmitche, AlitzelMendez, and dougbu via 2500833 February 29, 2024 21:51
@riarenas
Copy link
Member Author

@mmitche @dougbu or @chcosta I think this is good to go again. PTAL at your earliest convenience

@riarenas riarenas merged commit 903d35c into dotnet:main Feb 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants