-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DotNetBuildPass property in Arcade's Build.proj #14660
Open
ViktorHofer
wants to merge
11
commits into
main
Choose a base branch
from
SupportJoinPoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 27, 2024
-
Support DotNetBuildPass property in Arcade's Build.proj
1. Support DotNetBuildPass property Only build ProjectToBuild items with DotNetBuildPass metadata matching the passed-in value of DotNetBuildPass Don't glob for solution files in that build mode. Don't invoke the Execute target when nothing should be built. 2. Add SkipProjectToBuildError property to not error out when ProjectToBuild items are empty. This makes clean-up in source-build's outer build infrastructure possible (i.e. removal of Noop.proj) 3. Simplify Publish.proj Exec conditions in Build.proj 4. Add the DotNetBuildPass metadata to the asset manifest name when set. Also respect TargetArchitecture and TargetOS in the manifest name over Platform and OS. 5. Allow repos to invoke Arcade's Build.proj with the `-restore -sign -publish` actions only. For that to work, skip the ProjectToBuild empty error check when none of the build actions are passed in.
Configuration menu - View commit details
-
Copy full SHA for 52f8474 - Browse repository at this point
Copy the full SHA 52f8474View commit details
Commits on Mar 28, 2024
-
Update src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for ca489cc - Browse repository at this point
Copy the full SHA ca489ccView commit details -
Update src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for bde03ad - Browse repository at this point
Copy the full SHA bde03adView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccbc0ee - Browse repository at this point
Copy the full SHA ccbc0eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f745c6d - Browse repository at this point
Copy the full SHA f745c6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75eefba - Browse repository at this point
Copy the full SHA 75eefbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a723de - Browse repository at this point
Copy the full SHA 6a723deView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0de28b - Browse repository at this point
Copy the full SHA b0de28bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f17d0 - Browse repository at this point
Copy the full SHA 26f17d0View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d2bdf1f - Browse repository at this point
Copy the full SHA d2bdf1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9f8a93 - Browse repository at this point
Copy the full SHA f9f8a93View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.