Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to xunit 2.8.1 #14661

Merged
merged 14 commits into from
Jun 11, 2024
Merged

Update to xunit 2.8.1 #14661

merged 14 commits into from
Jun 11, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 28, 2024 •
edited

Fixes #14833

@ViktorHofer ViktorHofer self-assigned this Mar 28, 2024
@ViktorHofer
Squashed 'src/Microsoft.DotNet.XUnitAssert/src/' changes from cb1e33b…
a757c66 
…a6..574aebac4

574aebac4 xunit/xunit#2872: Expand special handling for sets in Assert.Contains/DoesNotContain
3b8edcbf1 xunit/xunit#2880: Update XML documentation for string-based Assert.Equal
d9f8361d2 Consolidate string and span-based Assert.Equal primary implementation
9ad71163e Move span-of-char assertions to StringAsserts and update docs/param names to indicate they're treated like strings
d70b34621 xunit/xunit#2871: Inner exception stack trace is missing from Assert.Collection failure
141681779 Missed #nullable enable in AsyncCollectionAsserts
22c89b0ea xunit/xunit#2367: Add IAsyncEnumerable<> overloads (.NET Core 3.0+)
d5c32630a While formatting type names in Assert.Equal/NotEqual, convert generated type names to '<generated>'
d7b807179 Add platform conditionals to support .NET 6 Roslyn Analyzers
6d9024665 xunit/xunit#2850: Assert.Equal failing value-slot collections of different concrete types (also fixed for KeyValuePair keys and values)
1f66b837a xunit/xunit#2811: Add SortedSet and ImmutableSortedSet overloads for Assert.Contains/DoesNotContain
1dab747d3 Update FuncEqualityComparer to throw if GetHashCode is called, and update EqualException/NotEqualException to process it
6e0a7cd70 xunit/xunit#2828: Prefer IEquatable<> over custom collection equality
c35ef46d5 xunit/xunit#2824: Assert.Equal fails with null values in dictionary
455865ac8 xunit/xunit#2821: Assert.Equal for collections of IEquatable objects don't call custom Equals
9af2c9c12 Clarify names for range comparer
2e6d9b267 Updates for .NET 8 SDK

git-subtree-dir: src/Microsoft.DotNet.XUnitAssert/src
git-subtree-split: 574aebac41dbbbf9e5e98bb9c65c6c5fab9b47f5
@ViktorHofer
Merge commit 'a757c663bdfea886cfc022f117cc12637283af06' into UpdateXU…
08aab05 
…nitToLatestStable
@akoeplinger
Copy link
Member

akoeplinger commented Mar 28, 2024 •
edited

We probably need to keep a close eye on this since we got report in xharness that 2.7.0 broke ABI again: dotnet/xharness#1170

IIRC that meant we needed to flow the xunit upgrade through the whole dependency tree.

akoeplinger
akoeplinger previously approved these changes Apr 3, 2024
View reviewed changes
src/Microsoft.DotNet.XUnitAssert/src/Sdk/Exceptions/ExceptionUtility.cs

static ExceptionUtility()
{
transformRegex = new Regex(@"^\s*at (?<method>.*) in (?<file>.*):(line )?(?<line>\d+)$");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should turn this into a source-generated Regex

@ViktorHofer
Squashed 'src/Microsoft.DotNet.XUnitAssert/src/' changes from 574aeba…
ea3e0d6 
…c4..5f68092bb

5f68092bb Polyfill StringSyntaxAttribute and decorate Assert.Matches/DoesNotMatch for Regex coloring
9e27603da Missing optional falses in StringAsserts
8502d0da4 Make note of NuGet package for Span/Memory usage in the README
884e68511 xunit/xunit#2913: Assert.Equivalent behaves incorrectly with decimal values
1c6ea0877 xunit/xunit#2903: Add ArgumentFormatter aliases for nint and nuint
adcd7cb67 xunit/xunit#2900: Add Assert.Raises overloads for Action
9fa0ed4f9 Use default(T) for raisedEvent values to prevent conditionals
9c5a0c4f3 Fix compile error when xunit.assert.source package is referenced by a project that also references xunit.core (#66)
9ca99a24b Add custom event handler assertion.
51e5d8c82 Move Memory<char> assertions to StringAsserts.cs, and more message consistency

git-subtree-dir: src/Microsoft.DotNet.XUnitAssert/src
git-subtree-split: 5f68092bb002cec936f3ed16c211479988050b5c
@ViktorHofer
Merge commit 'ea3e0d6165c05e42bfea7eb3987e7811273b2c3a' into UpdateXU…
039cbec 
…nitToLatestStable
@ViktorHofer ViktorHofer changed the title Update to xunit 2.7.0 Update to xunit 2.8.1 Jun 11, 2024
@ViktorHofer ViktorHofer mentioned this pull request Jun 11, 2024
Merged
@ViktorHofer
Copy link
Member Author

I manually cherry-picked all the xunit.assert test source code changes. That was a very unpleasant experience. I hope that we can eventually remove this fork to avoid these manual updates. cc @agocke

@ViktorHofer ViktorHofer merged commit ab55cdf into main Jun 11, 2024
15 checks passed
@ViktorHofer ViktorHofer deleted the UpdateXUnitToLatestStable branch June 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agocke agocke agocke approved these changes

@akoeplinger akoeplinger akoeplinger left review comments

Assignees

@ViktorHofer ViktorHofer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update xunit to 2.8.1
3 participants
@ViktorHofer @akoeplinger @agocke