Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port GenFacades, Microsft.Cci.Extensions to Arcade #477

Merged
merged 20 commits into from
Sep 12, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.DotNet.GenFacades/VersionResourceSerializer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ private void WriteVSFixedFileInfo(BinaryWriter writer)
//There's nothing guaranteeing that these are n.n.n.n format.
//The documentation says that if they're not that format the behavior is undefined.
Version fileVersion;
if (!Version.TryParse(_fileVersionContents, out fileVersion))
// For the File & Product Version, we take the first portion of the string before any whitespace,
// in case there is extraneous information (e.g. '@BuiltBy') after the version number.
if (!Version.TryParse(_fileVersionContents.Split(null)[0], out fileVersion))

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

fileVersion = new Version(0, 0);

Version productVersion;
// For the Product Version, we take the first portion of the string before any whitespace,
// in case there is extraneous information (e.g. '@BuiltBy') after the version number.
if (!Version.TryParse(_productVersionContents.Split(null)[0], out productVersion))
productVersion = new Version(0, 0);

Expand Down